Fix three verification failure causes in push, check_suite, and TrustSignal client#12
Merged
chrismaz11 merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
…check_suite detailsUrl Co-authored-by: chrismaz11 <24700273+chrismaz11@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix TrustSignal GitHub app functionality
Fix three verification failure causes in push, check_suite, and TrustSignal client
Mar 16, 2026
chrismaz11
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent bugs were causing spurious "TrustSignal Verification failed" check runs in GitHub.
Zero-SHA branch deletion events (
normalizePushPayload)GitHub sends
pushevents withafter = "000...0"when a branch is deleted. This was being forwarded asheadShato TrustSignal, producing a verification request for a non-existent commit and a guaranteed failure check run.check_suitedetailsUrl pointed to the REST API (normalizeCheckSuitePayload)detailsUrlwas set tocheckSuite.url(the API endpoint), so clicking "Details" on a check run opened raw JSON. Now usescheckSuite.html_urlwhen present, falling back to the commit URL.Missing
acceptheader in TrustSignal clientThe client wasn't sending
Accept: application/json. CDNs and reverse proxies commonly serve HTML error pages whenAcceptis absent, triggering the non-JSON fallback path unnecessarily or causing hard failures on the secondary endpoint.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.