fix: audit and clean up GitHub Actions CI workflows#57
Draft
fix: audit and clean up GitHub Actions CI workflows#57
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Remove unused `work` branch from push/PR triggers - Fix node-version 22 → '20' to match package.json engines constraint - Fix lint job: replace brittle hardcoded file list with `npm run lint` - Fix typecheck job: replace `npx tsc --strict --noEmit` (which type-checks nothing on a project-references tsconfig) with `npm run typecheck` (`tsc -b`) - Remove unnecessary secrets injection from lint, typecheck, web-build, rust-build, secret-scan, and dependency-audit jobs (least privilege) Co-authored-by: chrismaz11 <24700273+chrismaz11@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix GitHub Actions workflows for optimal CI setup
fix: audit and clean up GitHub Actions CI workflows
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five correctness issues in
ci.ymlthat together allowed broken or ineffective checks to silently pass, plus unnecessary secret exposure across six jobs.Changes
Triggers
workfrom push/PR branch triggers — branch doesn't exist; leftover noiseNode version
node-version: 22→'20'to matchpackage.jsonengines: { node: "20.x" }lintjobnpx eslint --no-ignore+ hardcoded file list withnpm run lint(eslint .)ignorePatternsand silently missed any file not in the listtypecheckjobnpx tsc --strict --noEmitwithnpm run typecheck(tsc -b)tsconfig.jsonhas"files": []and onlyreferences— the old command type-checked nothing;tsc -bis required to follow project referencesSecrets scope (least privilege)
DATABASE_URL,TRUSTSIGNAL_JWT_SECRET,TRUSTSIGNAL_JWT_SECRETS,POLYGON_RPC_URLfromlint,typecheck,web-build,rust-build,secret-scan,dependency-audittestandsigned-receipt-smokeactually consume those valuesNot changed:
scorecard.yml(correctly SHA-pinned),dependabot.yml(correct and minimal), all 8 jobs retained (each justified by actual repo content)AI Disclosure (optional)
Review Checklist
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.