Fix stale docs pages and remove dead lint script#1
Open
chrismaz11 wants to merge 1 commit intomainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR restores a clean pnpm build by updating two stale docs routes to use the current shared docs components and by removing an obsolete lint script that referenced tooling no longer present in the repo.
Changes:
- Removed the dead
lintscript frompackage.json. - Migrated
/docs/securityand/docs/threat-modelpages from removed components (DocsShell,SectionBlock, etc.) to the current docs component set (DocHeader,DocSection, etc.). - Updated the security docs page to use the new callout/code/diagram components (
DocCallout,DocCodeBlock,DocDiagram).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removes the stale lint script that referenced missing ESLint tooling. |
| app/docs/threat-model/page.tsx | Rewires the threat model page to the current shared docs components. |
| app/docs/security/page.tsx | Rewires the security page to the current shared docs components, including diagram/code/callout replacements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lintscript that referenced tooling not present in the repoWhy
Two documentation routes were still wired to component names that no longer exist in
app/docs/_components.tsx, which brokepnpm build. The package scripts also advertised aneslintcommand even though this repo no longer ships ESLint configuration or dependencies.Validation
corepack pnpm messaging:checkcorepack pnpm buildSecurity Review
Risks / Follow-ups
baseline-browser-mappingstaleness warnings from the current dependency tree, but validation passes without functional impact