Skip to content

🎨 Palette: [UX improvement] - Enhanced feedback and accessibility #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LVT-ENG wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: [UX improvement] - Enhanced feedback and accessibility #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ <h1>TRYONYOU</h1>
<li><a href="#features">Experiencia</a></li>
<li><a href="#try-on">Búnker</a></li>
<li><a href="#consultation">P.A.U.</a></li>
<li><a href="javascript:void(0)" onclick="requestPrivatePass()">Staff Access</a></li>
<li><a href="javascript:void(0)" onclick="requestPrivatePass()" aria-label="Acceso para el personal">Staff Access</a></li>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and accessibility, the visible link text should be in Spanish, matching the rest of the navigation menu. Using an aria-label for translation creates a mismatch between the visible text ('Staff Access') and what screen readers announce ('Acceso para el personal').

This violates WCAG 2.5.3 Label in Name, which requires the accessible name to contain the visible text. The best solution is to change the visible text to Spanish, which also makes the aria-label redundant.

Suggested change
<li><a href="javascript:void(0)" onclick="requestPrivatePass()" aria-label="Acceso para el personal">Staff Access</a></li>
<li><a href="javascript:void(0)" onclick="requestPrivatePass()">Acceso para el personal</a></li>

</ul>
</nav>
</header>
Expand Down Expand Up @@ -80,7 +80,7 @@ <h2 style="text-align: center; margin-bottom: 4rem;">P.A.U. Divineo AI</h2>
</div>
<button type="submit" class="cta-button" style="margin-top: 1rem;">Preguntar a P.A.U.</button>
</form>
<div id="jules-result" class="jules-result" style="display:none; margin-top: 4rem; padding: 2.5rem;">
<div id="jules-result" class="jules-result" style="display:none; margin-top: 4rem; padding: 2.5rem;" aria-live="polite">
<h3 style="margin-top: 0; color: #C5A46D; margin-bottom: 1.5rem;">Análisis de P.A.U.:</h3>
<p id="recommendation-text" style="white-space: pre-wrap; line-height: 1.8; font-weight: 300;"></p>
</div>
Expand All @@ -99,7 +99,7 @@ <h2 style="margin-bottom: 1rem;">Divineo Studio</h2>
<p>VISTA DE CÁMARA</p>
<p style="font-weight: 300; opacity: 0.5;">Click para iniciar experiencia Divineo</p>
</div>
<button class="camera-btn" onclick="toggleCamera()">Iniciar Escaneo Biométrico</button>
<button class="camera-btn" onclick="toggleCamera()" aria-label="Iniciar escaneo corporal biométrico para prueba virtual">Iniciar Escaneo Biométrico</button>
</div>
<div class="product-selector">
<h3>Catálogo Shopify</h3>
Expand All @@ -119,9 +119,9 @@ <h3>Catálogo Shopify</h3>
</section>

<!-- Private Pass Modal -->
<div id="private-pass-modal" class="modal" style="display:none; position:fixed; top:0; left:0; width:100%; height:100%; background:rgba(0,0,0,0.9); z-index:2000; align-items:center; justify-content:center;">
<div id="private-pass-modal" class="modal" style="display:none; position:fixed; top:0; left:0; width:100%; height:100%; background:rgba(0,0,0,0.9); z-index:2000; align-items:center; justify-content:center;" role="dialog" aria-modal="true" aria-labelledby="modal-title">
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding role="dialog" and aria-modal="true" is a great step towards making this modal accessible, a complete implementation requires JavaScript for focus management. Without it, the modal is not fully accessible for keyboard and screen reader users.

Specifically:

  1. When the modal opens, focus should be programmatically moved to an element inside it (e.g., the password input).
  2. While the modal is open, focus should be 'trapped' within it, so users cannot tab to elements in the background page.
  3. When the modal closes, focus should return to the element that originally opened it.

Since js/main.js is not part of this PR, I can't suggest the code, but this is a critical follow-up to ensure this feature is truly accessible.

<div class="modal-content" style="background:#141619; border:1px solid #C5A46D; padding:3rem; max-width:500px; text-align:center;">
<h3 style="color:#C5A46D; margin-bottom:1.5rem;">PASE PRIVADO SOLICITADO</h3>
<h3 id="modal-title" style="color:#C5A46D; margin-bottom:1.5rem;">PASE PRIVADO SOLICITADO</h3>
<p style="color:#F5EFE6; opacity:0.7; margin-bottom:2rem;">Contenido restringido para Curadores del Búnker. Por favor, introduce tu credencial de acceso.</p>
<input type="password" id="private-pass-input" placeholder="Credential ID" style="width:100%; padding:1rem; background:#0d0e10; border:1px solid rgba(255,255,255,0.1); color:#F5EFE6; margin-bottom:2rem;">
<div style="display:flex; gap:1rem; justify-content:center;">
Expand Down
23 changes: 23 additions & 0 deletions styles/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,29 @@ body {
.notification-success { border-left: 5px solid #4CAF50; }
.notification-error { border-left: 5px solid #f44336; }

/* Loader */
.loader {
width: 16px;
height: 16px;
border: 2px solid var(--bg-dark);
border-bottom-color: var(--accent-gold);
border-radius: 50%;
display: inline-block;
box-sizing: border-box;
animation: rotation 1s linear infinite;
margin-right: 10px;
vertical-align: middle;
}
Comment on lines +380 to +391
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a nice loader animation. To further improve accessibility for users sensitive to motion, please consider adding a prefers-reduced-motion media query to disable or reduce the animation. For example:

@media (prefers-reduced-motion: reduce) {
  .loader {
    animation: none;
  }
}


@keyframes rotation {
0% {
transform: rotate(0deg);
}
100% {
transform: rotate(360deg);
}
}

/* Responsive */
@media (max-width: 992px) {
.try-on-interface {
Expand Down