-
Notifications
You must be signed in to change notification settings - Fork 0
🛡️ Sentinel: [security improvement] Move staff verification to backend #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LVT-ENG
wants to merge
1
commit into
main
Choose a base branch
from
sentinel-staff-verification-8621098706126432433
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import pytest | ||
| from fastapi.testclient import TestClient | ||
| from backend.main import app | ||
|
|
||
| client = TestClient(app) | ||
|
|
||
| def test_verify_staff_success(monkeypatch): | ||
| """Test successful staff verification.""" | ||
| # Mock STAFF_PASSWORD in main module | ||
| monkeypatch.setattr("backend.main.STAFF_PASSWORD", "TEST_STAFF_PASS") | ||
|
|
||
| payload = {"password": "TEST_STAFF_PASS"} | ||
| response = client.post("/api/verify-staff", json=payload) | ||
|
|
||
| assert response.status_code == 200 | ||
| assert response.json() == {"status": "SUCCESS", "message": "Access granted"} | ||
|
|
||
| def test_verify_staff_failure(monkeypatch): | ||
| """Test failed staff verification.""" | ||
| # Mock STAFF_PASSWORD in main module | ||
| monkeypatch.setattr("backend.main.STAFF_PASSWORD", "TEST_STAFF_PASS") | ||
|
|
||
| payload = {"password": "WRONG_PASS"} | ||
| response = client.post("/api/verify-staff", json=payload) | ||
|
|
||
| assert response.status_code == 401 | ||
| assert response.json()["detail"] == "Access denied" | ||
|
|
||
| def test_verify_staff_empty_password(monkeypatch): | ||
| """Test verification with empty password.""" | ||
| monkeypatch.setattr("backend.main.STAFF_PASSWORD", "TEST_STAFF_PASS") | ||
|
|
||
| payload = {"password": ""} | ||
| response = client.post("/api/verify-staff", json=payload) | ||
|
|
||
| assert response.status_code == 401 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import { defineConfig } from 'vite'; | ||
|
|
||
| export default defineConfig({ | ||
| server: { | ||
| proxy: { | ||
| '/api': { | ||
| target: 'http://localhost:8000', | ||
| changeOrigin: true, | ||
| }, | ||
| }, | ||
| }, | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential security vulnerability here if the
STAFF_PASSWORDenvironment variable is set to an empty string. In that case, if an attacker sends a request with an empty password,hmac.compare_digest('', '')would returnTrue, granting them unauthorized access.To mitigate this, you should ensure that an empty password is never considered valid by checking that
STAFF_PASSWORDis not an empty string before performing the comparison.For more robust testing, you could also add a test case where
STAFF_PASSWORDis monkey-patched to an empty string to verify that access is denied for any provided password.