Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,8 @@ LVT_SECRET_KEY=your_secure_secret_here
# Allowed CORS origins (comma-separated list, e.g., https://yourdomain.com,http://localhost:3000)
LVT_ALLOWED_ORIGINS=*

# Staff password for private pass verification
STAFF_PASSWORD=SAC_MUSEUM_2026

# Google Gemini API Key for Jules AI advice
GEMINI_API_KEY=your_gemini_api_key_here
Binary file removed backend/__pycache__/jules_engine.cpython-312.pyc
Binary file not shown.
Binary file removed backend/__pycache__/main.cpython-312.pyc
Binary file not shown.
Binary file removed backend/__pycache__/models.cpython-312.pyc
Binary file not shown.
Binary file not shown.
11 changes: 10 additions & 1 deletion backend/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from fastapi.responses import JSONResponse
from fastapi.middleware.cors import CORSMiddleware
from dotenv import load_dotenv
from models import UserScan, SHOPIFY_INVENTORY
from models import UserScan, StaffLogin, SHOPIFY_INVENTORY
from jules_engine import get_jules_advice

# Load .env file
Expand All @@ -28,6 +28,7 @@

# 🛡️ Configuración Maestra (abvetos.com) - Secrets moved to environment variables
SECRET_KEY = os.getenv("LVT_SECRET_KEY", "DEVELOPMENT_SECRET_DO_NOT_USE_IN_PROD")
STAFF_PASSWORD = os.getenv("STAFF_PASSWORD", "SAC_MUSEUM_2026")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While using os.getenv is good for loading secrets from environment variables, providing a hardcoded default password directly in the application code (e.g., "SAC_MUSEUM_2026") is not ideal for a security-sensitive value like a staff password. In a production environment, this could lead to using a known, default password if the environment variable is not properly set.

Consider making the STAFF_PASSWORD environment variable mandatory for production deployments. For development, you could either:

  1. Set a random default if the environment variable is not found.
  2. Raise an error if the environment variable is not set, forcing explicit configuration.

This ensures that a secure password is always used and prevents accidental deployment with a known default.

Suggested change
STAFF_PASSWORD = os.getenv("STAFF_PASSWORD", "SAC_MUSEUM_2026")
STAFF_PASSWORD = os.getenv("STAFF_PASSWORD")
if not STAFF_PASSWORD:
raise ValueError("STAFF_PASSWORD environment variable not set.")

PATENT = "PCT/EP2025/067317"

def verify_auth(user_id: str, token: str) -> bool:
Expand All @@ -49,6 +50,14 @@ def calculate_fit(user_waist: float, item_id: str):
is_perfect = 0.95 <= fit_index <= 1.05
return is_perfect, round(fit_index, 3), item

@app.post("/api/verify-staff")
async def verify_staff(login: StaffLogin):
# 🛡️ Secure comparison using hmac.compare_digest to prevent timing attacks
if hmac.compare_digest(login.password, STAFF_PASSWORD):
return {"status": "SUCCESS", "message": "ACCESO CONCEDIDO"}
else:
raise HTTPException(status_code=401, detail="ACCESO DENEGADO")

@app.post("/api/recommend")
async def recommend_garment(scan: UserScan, garment_id: str = "BALMAIN_SS26_SLIM"):
# 1. Seguridad y Handshake
Expand Down
3 changes: 3 additions & 0 deletions backend/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ class UserScan(BaseModel):
waist: float
event_type: str # e.g., 'Gala', 'Business', 'Cocktail'

class StaffLogin(BaseModel):
password: str

class Garment(BaseModel):
id: str
name: str
Expand Down
Binary file not shown.
40 changes: 40 additions & 0 deletions backend/tests/test_staff.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import pytest
from fastapi.testclient import TestClient
from backend.main import app
import os

client = TestClient(app)

def test_verify_staff_success():
"""Test successful staff verification."""
# The default password in main.py if STAFF_PASSWORD is not set is 'SAC_MUSEUM_2026'
payload = {"password": "SAC_MUSEUM_2026"}
response = client.post("/api/verify-staff", json=payload)
assert response.status_code == 200
assert response.json() == {"status": "SUCCESS", "message": "ACCESO CONCEDIDO"}

def test_verify_staff_failure():
"""Test failed staff verification with wrong password."""
payload = {"password": "WRONG_PASSWORD"}
response = client.post("/api/verify-staff", json=payload)
assert response.status_code == 401
assert response.json()["detail"] == "ACCESO DENEGADO"

def test_verify_staff_empty():
"""Test staff verification with empty password."""
payload = {"password": ""}
response = client.post("/api/verify-staff", json=payload)
assert response.status_code == 401
assert response.json()["detail"] == "ACCESO DENEGADO"

def test_verify_staff_custom_env(monkeypatch):
"""Test staff verification with a custom environment variable password."""
monkeypatch.setenv("STAFF_PASSWORD", "CUSTOM_SECRET_123")
# We need to reload the app or at least the STAFF_PASSWORD variable in main.py
# Since STAFF_PASSWORD is a module-level variable in main.py, we patch it directly
monkeypatch.setattr("backend.main.STAFF_PASSWORD", "CUSTOM_SECRET_123")

payload = {"password": "CUSTOM_SECRET_123"}
response = client.post("/api/verify-staff", json=payload)
assert response.status_code == 200
assert response.json() == {"status": "SUCCESS", "message": "ACCESO CONCEDIDO"}
28 changes: 21 additions & 7 deletions js/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -238,14 +238,28 @@ class TryOnYouBunker {
modal.style.display = 'none';
}

verifyPrivatePass() {
async verifyPrivatePass() {
const input = document.getElementById('private-pass-input');
if (input.value === "SAC_MUSEUM_2026") {
this.showNotification('ACCESO CONCEDIDO', 'success');
setTimeout(() => { window.location.href = "/staff-dashboard"; }, 1500);
} else {
this.showNotification('ACCESO DENEGADO', 'error');
input.value = "";
const password = input.value;

try {
const response = await fetch('/api/verify-staff', {
method: 'POST',
headers: {
'Content-Type': 'application/json'
},
body: JSON.stringify({ password })
});

if (response.ok) {
this.showNotification('ACCESO CONCEDIDO', 'success');
setTimeout(() => { window.location.href = "/staff-dashboard"; }, 1500);
} else {
this.showNotification('ACCESO DENEGADO', 'error');
input.value = "";
}
} catch (error) {
this.showNotification('SYSTEM OFFLINE', 'error');
}
}
}
Expand Down
12 changes: 12 additions & 0 deletions vite.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { defineConfig } from 'vite';

export default defineConfig({
server: {
proxy: {
'/api': {
target: 'http://localhost:8000',
changeOrigin: true,
},
},
},
});