-
Notifications
You must be signed in to change notification settings - Fork 0
🛡️ Sentinel: [security improvement] Move staff verification to backend #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LVT-ENG
wants to merge
1
commit into
main
Choose a base branch
from
sentinel/move-staff-verification-to-backend-9127030693678809678
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import pytest | ||
| from fastapi.testclient import TestClient | ||
| from backend.main import app | ||
| import os | ||
|
|
||
| client = TestClient(app) | ||
|
|
||
| def test_verify_staff_success(): | ||
| """Test successful staff verification.""" | ||
| # The default password in main.py if STAFF_PASSWORD is not set is 'SAC_MUSEUM_2026' | ||
| payload = {"password": "SAC_MUSEUM_2026"} | ||
| response = client.post("/api/verify-staff", json=payload) | ||
| assert response.status_code == 200 | ||
| assert response.json() == {"status": "SUCCESS", "message": "ACCESO CONCEDIDO"} | ||
|
|
||
| def test_verify_staff_failure(): | ||
| """Test failed staff verification with wrong password.""" | ||
| payload = {"password": "WRONG_PASSWORD"} | ||
| response = client.post("/api/verify-staff", json=payload) | ||
| assert response.status_code == 401 | ||
| assert response.json()["detail"] == "ACCESO DENEGADO" | ||
|
|
||
| def test_verify_staff_empty(): | ||
| """Test staff verification with empty password.""" | ||
| payload = {"password": ""} | ||
| response = client.post("/api/verify-staff", json=payload) | ||
| assert response.status_code == 401 | ||
| assert response.json()["detail"] == "ACCESO DENEGADO" | ||
|
|
||
| def test_verify_staff_custom_env(monkeypatch): | ||
| """Test staff verification with a custom environment variable password.""" | ||
| monkeypatch.setenv("STAFF_PASSWORD", "CUSTOM_SECRET_123") | ||
| # We need to reload the app or at least the STAFF_PASSWORD variable in main.py | ||
| # Since STAFF_PASSWORD is a module-level variable in main.py, we patch it directly | ||
| monkeypatch.setattr("backend.main.STAFF_PASSWORD", "CUSTOM_SECRET_123") | ||
|
|
||
| payload = {"password": "CUSTOM_SECRET_123"} | ||
| response = client.post("/api/verify-staff", json=payload) | ||
| assert response.status_code == 200 | ||
| assert response.json() == {"status": "SUCCESS", "message": "ACCESO CONCEDIDO"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import { defineConfig } from 'vite'; | ||
|
|
||
| export default defineConfig({ | ||
| server: { | ||
| proxy: { | ||
| '/api': { | ||
| target: 'http://localhost:8000', | ||
| changeOrigin: true, | ||
| }, | ||
| }, | ||
| }, | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While using
os.getenvis good for loading secrets from environment variables, providing a hardcoded default password directly in the application code (e.g.,"SAC_MUSEUM_2026") is not ideal for a security-sensitive value like a staff password. In a production environment, this could lead to using a known, default password if the environment variable is not properly set.Consider making the
STAFF_PASSWORDenvironment variable mandatory for production deployments. For development, you could either:This ensures that a secure password is always used and prevents accidental deployment with a known default.