-
Notifications
You must be signed in to change notification settings - Fork 0
🛡️ Sentinel: [CRITICAL] Fix hardcoded staff password #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LVT-ENG
wants to merge
8
commits into
main
Choose a base branch
from
jules-8424711469455478886-e92ce9eb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b322baa
🛡️ Sentinel: [CRITICAL] Fix hardcoded staff password
google-labs-jules[bot] 0138756
Actualizar main.py
LVT-ENG aa9062d
Actualizar main.py
LVT-ENG 2d02bd5
Actualizar test_staff.py
LVT-ENG 994905b
Actualizar test_staff.py
LVT-ENG f13d555
Actualizar test_staff.py
LVT-ENG c98fe10
Fix test_staff.py: use backend.main for monkeypatch and add STAFF_PAS…
Copilot f10a412
Use generic test password to avoid revealing real password format
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| from fastapi.testclient import TestClient | ||
| from backend.main import app | ||
| import backend.main | ||
|
|
||
| TEST_STAFF_PASSWORD = "test_staff_password_123" | ||
|
|
||
| client = TestClient(app) | ||
|
|
||
| def test_verify_staff_success(monkeypatch): | ||
| """Test successful staff verification with correct password.""" | ||
| monkeypatch.setattr(backend.main, "STAFF_PASSWORD", TEST_STAFF_PASSWORD) | ||
| response = client.post("/api/verify-staff", json={"password": TEST_STAFF_PASSWORD}) | ||
| assert response.status_code == 200 | ||
| assert response.json() == {"status": "SUCCESS", "message": "Acceso concedido al búnker."} | ||
|
|
||
| def test_verify_staff_failure(monkeypatch): | ||
| """Test failed staff verification with incorrect password.""" | ||
| monkeypatch.setattr(backend.main, "STAFF_PASSWORD", TEST_STAFF_PASSWORD) | ||
| response = client.post("/api/verify-staff", json={"password": "WRONG_PASSWORD"}) | ||
| assert response.status_code == 401 | ||
| assert response.json() == {"detail": "Credencial de acceso denegada."} | ||
|
|
||
| def test_verify_staff_empty(monkeypatch): | ||
| """Test staff verification with empty password.""" | ||
LVT-ENG marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| monkeypatch.setattr(backend.main, "STAFF_PASSWORD", TEST_STAFF_PASSWORD) | ||
| response = client.post("/api/verify-staff", json={"password": ""}) | ||
| assert response.status_code == 401 | ||
| assert response.json() == {"detail": "Credencial de acceso denegada."} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import { defineConfig } from 'vite'; | ||
|
|
||
| export default defineConfig({ | ||
| server: { | ||
| proxy: { | ||
| '/api': { | ||
| target: 'http://localhost:8000', | ||
| changeOrigin: true, | ||
| }, | ||
| }, | ||
| }, | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.