This repository was archived by the owner on May 8, 2025. It is now read-only.
Feature/enhance nsgaii settings #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er in NSGAIISettingsPage
…tion and crossover types
…ection with updated handling for parameters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the GA base algorithm by introducing additional mutation and crossover settings, improving configuration and UI support.
- Added a new BLXAlpha settings page for crossover parameter input.
- Introduced new enums and interfaces for mutation and crossover parameters.
- Updated GA sampler implementations and commit references for the Optuna integration.
Reviewed Changes
Copilot reviewed 40 out of 43 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Tunny/WPF/Views/Pages/Settings/Crossover/BLXAlpha.xaml.cs | New page for BLXAlpha settings with UI input for alpha. |
| Tunny/WPF/ViewModels/MainWindowViewModel.cs | Added deletion logic for Python directory with error logging. |
| Tunny/WPF/Common/NsgaMutationType.cs | New enum for NSGA mutation types. |
| Tunny/WPF/Common/NsgaCrossoverType.cs | Updated namespace for NSGA crossover types. |
| Tunny/WPF/Common/IMutationParam.cs | Introduced interface for mutation parameters. |
| Tunny/WPF/Common/ICrossoverParam.cs | Introduced interface for crossover parameters. |
| Tunny.Core/Util/TEnvVariables.cs | Added documentation for environment paths. |
| Tunny.Core/Settings/Sampler.cs | Updated commit SHA for Optuna integration. |
| Tunny.Core/Input/InputValidator.cs | Enhanced methods to support boundary inclusion options. |
| Optuna/Sampler/TpeSampler.cs | Added JsonIgnore for WarnIndependentSampling property. |
| Optuna/Sampler/QMCSampler.cs | Added JsonIgnore for warning properties. |
| Optuna/Sampler/OptunaHub/NSGAIISampler.cs | Updated parameter passing for crossover and mutation. |
| Optuna/Sampler/OptunaHub/MOEADSampler.cs | Updated GA sampler configuration to use new interfaces. |
| Optuna/Sampler/NSGAIIISampler.cs | Minor adjustments in parameter passing consistency. |
| Optuna/Sampler/GASamplerBase.cs | Introduced new settings properties and updated crossover logic. |
| Optuna/Sampler/CmaEsSampler.cs | Added JsonIgnore for WarnIndependentSampling property. |
| CHANGELOG.md | Documented changes and version update for optuna. |
Files not reviewed (3)
- Tunny/Tunny.csproj: Language not supported
- Tunny/WPF/Views/Pages/Optimize/OptimizePage.xaml: Language not supported
- Tunny/WPF/Views/Pages/Settings/Crossover/BLXAlpha.xaml: Language not supported
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #454 +/- ##
===========================================
- Coverage 44.89% 44.86% -0.03%
===========================================
Files 70 70
Lines 3288 3299 +11
Branches 375 381 +6
===========================================
+ Hits 1476 1480 +4
- Misses 1765 1771 +6
- Partials 47 48 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code Climate has analyzed commit 6dd599b and detected 16 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.