-
Notifications
You must be signed in to change notification settings - Fork 308
Add extension: RubyFS #2338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add extension: RubyFS #2338
Conversation
(extensions.json wasn't updated yet)
|
Wow, thanks to the three failed checks that made me look like a terrible GitHub user... Working on that now. |
|
"thoroughly reviewed the code" I say, as three of my checks fail immediately... |
|
Issues fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all LLM-generated code from this extension.
This comment was marked as resolved.
This comment was marked as resolved.
My apologies, one of the checks (I'm pretty sure) failed for one reason, which was because TL;DR, I'll remove the Half of me expected to be sworn into Hell for writing an extension with an LLM, but maybe TurboWarp extension developers are nicer than I perceived. |
That perception was probably my fault, sorry. |
Just saw this lol... If you actually mean this, I can kiss goodbye to LiFS in the TurboWarp Extension Gallery, because as I said, this extension is almost completely LLM-generated. Although, I can't say I didn't expect this. |
I do, but I was a bit harsh. @Brackets-Coder is pretty kind, maybe they can overrule me here? |
|
While I'm not opposed to the constructive and supportive use of AI in a developer's workflow, I don't think Turbowarp as a whole accepts extensions generated entirely with AI, mostly because large projects generate with AI deteriorate in quality and functionality. If this extension still proves functional and has no glaring issues, then I'm not opposed to merging it (unless there's a serious licensing problem I'm not aware of), but then again we don't like extensions generated entirely with AI. |
I am yet to develop an entire project with LiFS (however I might with an expansion of one my of in-development Scratch games), but from my testing, every block works, and stress testing completed successfully. You can even turn on console logging if some blocks don't work. I don't really find an issue with LLMs creating extensions, but your claim on projects developed by AI deteriorating is valid, and has happened to me before -- but not with LiFS. Sorry if I sound stupid right now (I probably am). |
|
Your thumbnail's pretty awesome! |
Thank you! I made it in Canva. |
NOTE: This breaks the banner! I'll rename the banner next, shouldn't take me a long time.
Hopefully this one works(?)
|
@ohgodwhy2k I'm a bit busy at the moment; would someone else be willing to review in my place? |
- New child indexing (O(1)) - Trash feature - New "empty trash" block
|
Might mark this as a draft because I'm constantly updating RubyFS, not sure though. |
If your extension is not yet finalized that would be the best thing to do for organization and clarity |
|
I love how this got marked as draft and as soon as it did, no more updates happened until forever. I'll probably keep it as a draft until RubyFS v2.0.0. |
If you're concerned about your lack of progress and the extension is functional now, it might be better to have it merged and push major updates later |
|
If the extension requires significant work to be production-ready I would keep it as a draft. |
@ohgodwhy2k To add to this comment, I think that it's worth noting that you can always distribute your extension unofficially in the meantime. |
I don't think this extension needs work to be production ready, I just want to wait to add more features (however RubyFs's block set is rather humongous). |
If this is ready now we can start the review process and you can add more features later. |
Yeah, it is. Sorry if I'm sounding tight-fisted or hard to work with. I'm not very educated on pull requests so I'm bound to get something wrong. But yes, reviewing can start now if you want. (thumbs-up emoji) |
We all have to start from somewhere; I made several failed PRs (#1492, #1495 and #1995 were some of the worst) before I could get anything merged. |
Read the first PR and a Fetch+ extension with a built-in CORS proxy would be pretty nice. |
|
Hi @Brackets-Coder @PPPDUD — quick ping: all checks pass and I’ve audited/fixed the earlier issues. I manually tested all core blocks (create/open/list/copy/delete, import/export) and ran the built-in integrity test (PASS). I used LLMs to assist testing/debugging but I personally reviewed the code, and everything seems to work. Could you re-check and approve if everything looks OK, or let me know any remaining changes? Thanks! |
New Extension: RubyFS (
rubyFS)This PR introduces RubyFS, an unsandboxed extension that provides a robust, in-memory filesystem environment for TurboWarp projects.
RubyFS is an advancement of the original rxFS concept, designed to give creators more control and security within their virtual file structures.
Key features
The following features distinguish RubyFS from the existing
0832/rxFS2extension, justifying its inclusion as a separate extension rather than a modification:Technical compliance
MIT) and is GPLv3-compatible.Scratch.translateused to exist prior to this PR's creation, but is no longer included here because it caused a required check to fail.Note on this code's origin
Almost the entirety this extension were developed with the assistance of an AI programming tool. I have thoroughly reviewed the code, performed extensive testing, and verified that it meets the required safety and functionality standards before submitting this PR. I used to have a tester program, but I suck at resource management and I reset my PC without backing it up.