-
Notifications
You must be signed in to change notification settings - Fork 230
Update variational inference interface to match AdvancedVI@0.6
#2699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: breaking
Are you sure you want to change the base?
Conversation
|
Turing.jl documentation for PR #2699 is available at: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## breaking #2699 +/- ##
============================================
+ Coverage 86.54% 87.49% +0.94%
============================================
Files 21 20 -1
Lines 1412 1415 +3
============================================
+ Hits 1222 1238 +16
+ Misses 190 177 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhauru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Red-Portal.
Since this changes the user-interface, could you please set the target branch of this PR to be breaking? We use that branch to collect breaking changes into a single, larger release. Currently breaking points at the same commit as main, so you shouldn't have to mess with git history for this.
In that same process, could you also please add an entry in HISTORY.md describing to users all interface changes (arguments, return values, behaviour) and what they can do to adapt to them. Maybe a code example of "this is how you used to call vi, this is how you do the same thing now", that sort of thing.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I'm actually sorry to butt in on this, but are there new features available in 0.5, or is it just an interface change? |
|
@penelopeysm No new features. |
|
Okay. The reason why I asked is because this is an interface change for Turing and that is kind of annoying for end users if they don't get any benefit. I wonder in that case if it is worth doing either:
Other than that, I second everything that @mhauru brought up here, so I won't also review the details of this. |
Co-authored-by: Markus Hauru <markus@mhauru.org>
Co-authored-by: Markus Hauru <markus@mhauru.org>
AdvancedVI@0.5AdvancedVI@0.6
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… into bump_advancedvi_0.5
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Hi @penelopeysm @mhauru @yebai , I've updated the code to match the new v0.6 version. Let me know if you have any comments! |
This PR does the following:
AdvancedVIis updated to match the new v0.6 version.vicallsoptimizeis slightly changed so that algorithms that expect an unconstrained space can be used without being aware ofBijectors. In particular, the user is now expected to provide aq <: Bijectors.TransformedDistribution.viwill then unwrap the underlying unconstrained distribution, which is passed toAdvancedVI. Once the algorithm terminates, the result will be wrapped back and then returned. (See also this PR for a more detailed explanation.)VariationalInference.jltoVariational.jlto match the submodule nameVariational.