Make BARONY_SUPER_MULTIPLAYER functional#824
Open
elliot-gh wants to merge 1 commit intoTurningWheel:masterfrom
Open
Make BARONY_SUPER_MULTIPLAYER functional#824elliot-gh wants to merge 1 commit intoTurningWheel:masterfrom
elliot-gh wants to merge 1 commit intoTurningWheel:masterfrom
Conversation
Collaborator
|
Nice work, we have assets for additional player deathboxes (they actually are designed for color remixing) but not XP bars I think. Ghosts need their own assets too. |
Collaborator
|
We also want to improve the user interface so the lobby browser correctly shows lobbies with greater >4 players, you can adjust the player count properly as a host, kick players, and the default player count remains 4. Raising the player count above that shows a pop-up box talking about instability, game design issues with more than 4 players, etc. |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the precompiler directive
BARONY_SUPER_MULTIPLAYERand makes it functional (though still buggy). I do not have Steamworks or EOS so this has only been tested both with multiple local instances and LAN mode with port forwarding over internet.Fixes:
NET_PACKET_SIZEbeing larger than the packet data used to load an existing 8 player save. Thechunk_sizeinlobbyPlayerJoinRequest()is 98 bytes, and the packet length is defined as8 + MAXPLAYERS * chunk_size, resulting in a total of 792 bytes. The oldNET_PACKET_SIZEis 512, which is too small. I'm not sure what's a good number so I just doubled it.USE_PLAYFABoff since I didn't have the libraries/includes, so I moved the includes underneath it.Bugs: