Basic support for name mode queries#32
Open
ghormoon wants to merge 1 commit intoTuxInvader:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial support for queries having name= arguments instead of pre-crafted dns= argument.
type= is optional, default is 'A' if not provided.
I'd appreciate any feedback and more testing in different usecases (e.g. I'm not sure how to properly test the scrub condition, I didn't make it work with dns= either in my usecase)
this feature is extremely useful if you want to use if tom some app (including from another njs function as subrequest) that doesn't know how to craft the dns query and you don't want to re-implement it.
example usage
fixes #30 and #25 (and potentially others that i missed or didn't explicitly state what query are they using, but have simmilar backend errors)