Rjb fix master for modern ruby#10
Open
rberger wants to merge 8 commits intoTwP:masterfrom
Open
Conversation
…modern_ruby * rjb_0.9.4_fix_for_modern_ruby: Check for symbols instead of strings when undefing methods Added a bit more error handling for when an input file has corrupt metadata Fixed main to properly import rake task and ruby tasks with modern ruby and rake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some fixes that at least make webby work (for some value of work that was good enough for me). I didn't bother to get the rspec tests to run since they seem based on an ancient version of rspec
This addresses issues #7 and #9
The meaningful fix is the change from import to app.add_import and making file paths get expanded to full paths by File.expand_path in lib/webby/apps/main.rb