fix: Table column widths not being set in exported HTML #1947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
YousefED
reviewed
Aug 18, 2025
| this.name, | ||
| "table", | ||
| { | ||
| ...(this.options.domAttributes?.blockContent || {}), | ||
| ...(this.options.domAttributes?.blockContent || { fesfes: "fesfes" }), |
nperez0111
reviewed
Aug 21, 2025
| renderHTML({ HTMLAttributes }) { | ||
| return ["p", HTMLAttributes, 0]; | ||
| renderHTML({ node, HTMLAttributes }) { | ||
| return ["p", HTMLAttributes, node.childCount ? 0 : ["br"]]; |
nperez0111
reviewed
Aug 21, 2025
Comment on lines
+48
to
+71
| // Need to manually add column widths. | ||
| const cols: HTMLTableColElement[] = []; | ||
| for (const tableCell of node.children[0].children) { | ||
| const colWidths: null | (number | undefined)[] = | ||
| tableCell.attrs["colwidth"]; | ||
|
|
||
| if (colWidths) { | ||
| for (const colWidth of tableCell.attrs["colwidth"]) { | ||
| const col = document.createElement("col"); | ||
| if (colWidth) { | ||
| col.style = `width: ${colWidth}px`; | ||
| } | ||
|
|
||
| cols.push(col); | ||
| } | ||
| } else { | ||
| cols.push(document.createElement("col")); | ||
| } | ||
| } | ||
|
|
||
| const colGroup = document.createElement("colgroup"); | ||
| for (const col of cols) { | ||
| colGroup.appendChild(col); | ||
| } |
There was a problem hiding this comment.
Suggested change
| // Need to manually add column widths. | |
| const cols: HTMLTableColElement[] = []; | |
| for (const tableCell of node.children[0].children) { | |
| const colWidths: null | (number | undefined)[] = | |
| tableCell.attrs["colwidth"]; | |
| if (colWidths) { | |
| for (const colWidth of tableCell.attrs["colwidth"]) { | |
| const col = document.createElement("col"); | |
| if (colWidth) { | |
| col.style = `width: ${colWidth}px`; | |
| } | |
| cols.push(col); | |
| } | |
| } else { | |
| cols.push(document.createElement("col")); | |
| } | |
| } | |
| const colGroup = document.createElement("colgroup"); | |
| for (const col of cols) { | |
| colGroup.appendChild(col); | |
| } | |
| // Need to manually add colgroup element | |
| const colGroup = document.createElement("colgroup"); | |
| for (const tableCell of node.children[0].children) { | |
| const colWidths: null | (number | undefined)[] = | |
| tableCell.attrs["colwidth"]; | |
| if (colWidths) { | |
| for (const colWidth of tableCell.attrs["colwidth"]) { | |
| const col = document.createElement("col"); | |
| if (colWidth) { | |
| col.style = `width: ${colWidth}px`; | |
| } | |
| colGroup.appendChild(col); | |
| } | |
| } else { | |
| colGroup.appendChild(document.createElement("col")); | |
| } | |
| } |
Just makes it a bit clearer what is happening here without the extra insertion loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1574
TODO: Empty paragraphs should also include a line break for correct row height.