Fix importing duplicate Configuration class, add dotenv to manage environmental configurations #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ronments Instead of hardcoding the configurations in the project, using dotenv could help the developers to set up their local dev environment without revise anything in the project. Also, for production deployment, environment variables could be loaded by dockerfile. I think it's the best way to configure the environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix:
In
src/main/scala/model/OfficeHoursServer,Configurationimported twice with the same name (model.Configuration,com.corundumstudio.socketio.Configuration)Feature Added:
Using dotenv to manage environmental configurations