finished the navigation challenge#11
Open
vijeeth19 wants to merge 3 commits intoUBC-Snowbots:masterfrom
Open
Conversation
ihsan314
requested changes
Mar 7, 2020
ihsan314
left a comment
ihsan314
left a comment
There was a problem hiding this comment.
Overall pretty good, just a few minor issues regarding standard coding practices and extraneous code.
|
|
||
|
|
||
|
|
||
| MyClass::MyClass(int argc, char **argv, std::string node_name) { |
There was a problem hiding this comment.
A more meaningful class name would have been nice.
Comment on lines
+25
to
+28
| // Obtains character from the parameter server (or launch file), sets '!' as default | ||
| std::string parameter_name = "my_node/character"; | ||
| std::string default_character = "!"; | ||
| SB_getParam(nh, parameter_name, suffix, default_character); |
There was a problem hiding this comment.
This code isn't used, so you can get rid of it.
Comment on lines
+39
to
+41
| void convertToPointCloud(float * ranges, sensor_msgs::PointCloud* cloud, int size, float angle_min, float angle_incr); | ||
| float locateTheHole(sensor_msgs::PointCloud* cloud, geometry_msgs::Point32* output_points, int size, float angle_min, float angle_incr); | ||
| void MoveTowardsHole(geometry_msgs::Twist* twist, float hole_angle); |
There was a problem hiding this comment.
These functions should be kept private, per standard C++ practice.
| @@ -0,0 +1,5 @@ | |||
| <launch> | |||
| <node name="my_node" pkg="obstacle_avoidance" type="my_node" output="screen"> | |||
There was a problem hiding this comment.
The node could have a more descriptive name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.