Fix R oldrel-1 CI failure: replace ggpubr with patchwork + graceful internet error handling#508
Draft
Fix R oldrel-1 CI failure: replace ggpubr with patchwork + graceful internet error handling#508
Conversation
Copilot
AI
changed the title
[WIP] Fix errors identified in PR #506
Fix R oldrel-1 CI failure: replace ggpubr with patchwork + graceful internet error handling
Mar 6, 2026
kristinawlai
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #506 was failing on
ubuntu-latest (oldrel-1)becauseggpubr→ggrepel >= 0.9.2→ R >= 4.5.0, breaking dependency resolution on R 4.4.x. This PR applies the fix from PR #507 (dropggpubrforpatchwork) alongside the internet-resource error handling from PR #506.Changes
Dependency fix (PR #507)
ggpubr::ggarrange()withpatchwork::wrap_plots()inautoplot.seroincidence.by.Randgraph_seroresponse_model_1.Rggpubr→patchworkinDESCRIPTIONImports; removes transitiveggrepeldependencyGraceful internet resource errors (PR #506)
load_noise_params()andload_sr_params(): wrap URL loading intryCatch+withCallingHandlers; emitcli::cli_abort()with classinternet_resource_unavailableon failure; re-signal non-URL errors unchanged viarlang::cnd_signal()readRDS()toreadr::read_rds(); movereadrfrom Suggests → Importsload_curve_params()Misc
Fix pre-existing
stop()→cli::cli_abort()inautoplot.seroincidence.by.R(linter flags modified files)Add
tests/vdiffr.Rout.failto.gitignoreBump version to 1.4.0.9004
The title of your PR should briefly describe the change.
The body of your PR should contain
Fixes #issue-number(if relevant).Commit/merge messages to be included in NEWS.md should begin with
-.Code should follow the tidyverse style guide.
Documentation should use roxygen2, with Markdown syntax.
Contributions should include unit tests (using
testthat).For more information see Contributing.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.