Skip to content

Fix LaTeX octave diacritics visual inconsistency#23

Merged
jon-myers merged 1 commit intomainfrom
issue-21-implementation
Sep 8, 2025
Merged

Fix LaTeX octave diacritics visual inconsistency#23
jon-myers merged 1 commit intomainfrom
issue-21-implementation

Conversation

@jon-myers
Copy link
Contributor

Fixes Issue #21 by replacing bold bullet symbols with thin dots for consistent LaTeX octave diacritics.

Changes:

  • Lower octave diacritics now use consistent dot symbols
  • Updated all tests to match new symbols
  • Maintains visual consistency between upper and lower octave markings

Resolves #21

- Replace \bullet with \cdot in lower octave diacritics
- Ensures visual consistency between upper (\dot) and lower (\cdot) octave markings
- Fixes Issue #21: LaTeX octave diacritics had inconsistent visual weights
- Update all corresponding test expectations

Before: Upper octaves used thin \dot, lower octaves used bold \bullet
After: Both upper and lower octaves use similarly-weighted dot symbols

This improves visual consistency in matplotlib visualizations that use
the latex_octaved_sargam_letter property for musical notation rendering.

Resolves #21
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

📦 Test Package Built Successfully!

This PR has been automatically built and uploaded to TestPyPI for testing.

🔗 TestPyPI Link: https://test.pypi.org/project/idtap/

To test this version:

pip install --index-url https://test.pypi.org/simple/ idtap

✅ All tests passed and package builds successfully.

@jon-myers jon-myers merged commit 1276a07 into main Sep 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LaTeX octave diacritics have inconsistent visual weights

1 participant