Aux BMS Rearchitecture #183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should double check DMA, ADC and SPI settings
Only difficulty is that for CMSIS v2, CubeMx does not support memory pools so we are assuming we'll be fine with just queues. Worst case, we'll use pvMalloc and pvFree for dynamic allocation.
…ine-and-initialize-variables User/embedded/sft 167 define and initialize variables
Created functions, tasks, and unit tests relating to contactor control.
…ate-functions-and-unit-tests-relating-to-contactor-control User/embedded/sft 175 create functions and unit tests relating to contactor control
…peripheral-configs-and-initializations CAN Interrupt and Filter Config
…ate-functions-and-unit-test-relating-to-orion-work User/embedded/sft 190 create functions and unit test relating to orion work
…200-Create-functions-relating-to-CAN-Tx-work
…ate-functions-relating-to-CAN-Tx-work User/embedded/sft 200 create functions relating to can tx work
…CSolarCarTeam/Epsilon-Embedded-Software into user/embedded/SFT-202-Creating-functions-and-unit-tests-relating-to-aux-voltage-reading-work
…ating-functions-and-unit-tests-relating-to-aux-voltage-reading-work User/embedded/sft 202 creating functions and unit tests relating to aux voltage reading work
…ating-functions-and-unit-tests-relating-to-aux-voltage-reading-work Adding unit tests
Implemented stack overflow hook, and malloc failed hook, and error handler
…lement-error-handling SFT 203. Implementing error handling
…lement-memory-debug-tasks SFT 204. Implemented memory debug task
badeniran
requested review from
JessieG123,
avneetgill,
bill-luu,
duan-le,
islamrahat735 and
maaryaahmed
Contributor
|
@bill-luu, @badeniran please take a look when you are free |
badeniran
commented
Mar 13, 2021
Member
Author
badeniran
left a comment
badeniran
left a comment
There was a problem hiding this comment.
Looking good! Just a few changes and questions
EpsilonAuxBmsV2/Tests/tests/OrionInterfaceTest/OrionInterfaceTest.c
Outdated
Show resolved
Hide resolved
EpsilonAuxBmsV2/Tests/tests/OrionInterfaceTest/OrionInterfaceTest.c
Outdated
Show resolved
Hide resolved
| AuxBmsContactorState expectedAuxBmsContactorState = {.contactorsDisconnected = 1}; | ||
| uint32_t contactorControlEventFlags = 0x28; // CHARGE_OPENED and DISCHARGE_OPENED | ||
|
|
||
| osMessageQueueGet_ExpectAndReturn(orionInterfaceQueue, &message, NULL, ORION_QUEUE_TIMEOUT, osErrorTimeout); |
Member
Author
There was a problem hiding this comment.
Not sure if you meant for this to return osErrorTimeout
Contributor
There was a problem hiding this comment.
if (status == osErrorTimeout) // If waiting on the queue times out
{
//Set orion can message recieved recently to 0
localAuxStatus.orionCanReceivedRecently = 0;
}
else
{
// Determine trip conditions and contactor settings based on Orion CAN
localAuxStatus.orionCanReceivedRecently = 1;
updateAllowChargeAndAllowDischarge(message, &localAuxStatus);
updateAuxTrip(message, &localAuxTrip);
localAuxStatus.dischargeShouldTrip = checkDischargeTrip(localAuxTrip);
localAuxStatus.chargeShouldTrip = checkChargeTrip(localAuxTrip);
shouldDisconnectContactors = localAuxTrip.protectionTrip
|| localAuxStatus.dischargeShouldTrip
|| localAuxStatus.chargeShouldTrip;
}
We were not able to test this else block because of the localAuxTrip being a local variable. That's why we were returning osErrorTimeout. Not sure if there is a way to test this particular block, but we did test most of these functions in TripTest.c.
Member
Author
There was a problem hiding this comment.
I can think of two ways:
- Don't mock the Trip functions. This will make testing incredibly messy
- Make
localAuxTripnot local to the function. This is less clean in the actual design code, but cleaner for testing
Either way, I think it's very critical to test this point as this has all the trip functionality.
@bill-luu what do you think?
…t-fixes OrionInterfaceTest final fixes
badeniran
commented
Mar 15, 2021
| AuxBmsContactorState expectedAuxBmsContactorState = {.contactorsDisconnected = 1}; | ||
| uint32_t contactorControlEventFlags = 0x28; // CHARGE_OPENED and DISCHARGE_OPENED | ||
|
|
||
| osMessageQueueGet_ExpectAndReturn(orionInterfaceQueue, &message, NULL, ORION_QUEUE_TIMEOUT, osErrorTimeout); |
Member
Author
There was a problem hiding this comment.
I can think of two ways:
- Don't mock the Trip functions. This will make testing incredibly messy
- Make
localAuxTripnot local to the function. This is less clean in the actual design code, but cleaner for testing
Either way, I think it's very critical to test this point as this has all the trip functionality.
@bill-luu what do you think?
JessieG123
reviewed
Jan 29, 2022
| Charge will cause a trip due to: | ||
| * the max cell voltage being higher than the Orion limit | ||
| * high temperature while charging | ||
| * discharge pack current being too high (absolute value) |
Contributor
There was a problem hiding this comment.
This should be charge right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviews to review logic and code. Will begin functional testing in Winter 2021. The pull request will remain open until we know that the new aux BMS is functional.
The design is based on these two documents:
Aux BMS Architecture V2 - Proposal
Aux BMS Architecture V2 - Diagram