Created functional battery component #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeeyaSomaiya
requested changes
Dec 3, 2025
content/Components/BatteryIcon.qml
Outdated
| width: 170 | ||
| height: 60 | ||
| width: 265 | ||
| height: 367 |
content/Components/BatteryIcon.qml
Outdated
| width: 35 | ||
| height: 60 | ||
| width: 31 | ||
| height: 25.71 |
content/Components/BatteryIcon.qml
Outdated
| Rectangle { | ||
| id: batteryGauge | ||
| width: 342 | ||
| height: 23.14 |
content/Components/BatteryIcon.qml
Outdated
| radius:15 | ||
| anchors.bottom: parent.bottom | ||
| color: Config.primary | ||
| color: Config.valueModerate |
Contributor
There was a problem hiding this comment.
color should correspond with value, ie. very low is red, medium is yellow, nearly full to full is green
content/Components/BatteryIcon.qml
Outdated
| Text { | ||
| id: batteryLow | ||
| width: 37 | ||
| height: 16.29 |
content/Components/BatteryIcon.qml
Outdated
| Text { | ||
| id: batteryHigh | ||
| width: 74 | ||
| height: 16.29 |
content/Components/BatteryIcon.qml
Outdated
| property real rawValue: battery.PackStateOfCharge | ||
| property real value: rawValue / 2 //Unit Conversion from 0.5% to 1% | ||
|
|
||
| Image { |
Contributor
There was a problem hiding this comment.
battery icon and value are not centered in component
Contributor
There was a problem hiding this comment.
picture is extremely small and looks grainy on dashboard, replace with larger image
JeeyaSomaiya
requested changes
Dec 6, 2025
| id: batteryImage | ||
| width: 35 | ||
| height: 60 | ||
| function getBatteryColor(value) { |
Contributor
There was a problem hiding this comment.
color changes harshly from 24 to 25 and from 74 to 75, should be a smooth gradient from one color to the next, not a sudden change
| } | ||
| } | ||
| Item{ | ||
| width:60 |
Contributor
There was a problem hiding this comment.
inconsistent spacing around colon
| width:60 | ||
| height:25 | ||
| id: batteryImageAndPercentage | ||
| anchors{ |
| return Config.valueHigh | ||
| } | ||
| } | ||
| Item{ |
| verticalAlignment: Text.AlignVCenter | ||
| font.weight: Font.Medium | ||
| font.family: Config.fontStyle | ||
| } |
Contributor
There was a problem hiding this comment.
normalize indentation for this item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.