-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add example environment variables for server package #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds a new example environment file at Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🪛 dotenv-linter (4.0.0)packages/server/.env.example[warning] 8-8: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 9-9: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 10-10: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 10-10: [UnorderedKey] The DRIVER_TABLE_NAME key should go before the LAP_TABLE_NAME key (UnorderedKey) [warning] 11-11: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 11-11: [UnorderedKey] The GPS_CALCULATED_LAP_DATA_TABLE key should go before the LAP_TABLE_NAME key (UnorderedKey) [warning] 12-12: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 12-12: [UnorderedKey] The GPS_TABLE_NAME key should go before the LAP_TABLE_NAME key (UnorderedKey) [warning] 25-25: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 26-26: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 26-26: [UnorderedKey] The LOKI_PASSWORD key should go before the LOKI_USERNAME key (UnorderedKey) [warning] 30-30: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 35-35: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 36-36: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 36-36: [UnorderedKey] The MQTT_PASSWORD key should go before the MQTT_USERNAME key (UnorderedKey) [warning] 41-41: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 42-42: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 47-47: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 48-48: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 50-50: [UnorderedKey] The LOG_ERROR_STACK key should go before the LOG_FILE key (UnorderedKey) [warning] 56-56: [QuoteCharacter] The value has quote characters (', ") (QuoteCharacter) [warning] 56-56: [UnorderedKey] The ENV key should go before the LOG_DIR key (UnorderedKey) 🔇 Additional comments (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/server/.env.example(1 hunks)
🧰 Additional context used
🪛 dotenv-linter (4.0.0)
packages/server/.env.example
[warning] 5-5: [ExtraBlankLine] Extra blank line detected
(ExtraBlankLine)
[warning] 6-6: [ExtraBlankLine] Extra blank line detected
(ExtraBlankLine)
[warning] 9-9: [ValueWithoutQuotes] This value needs to be surrounded in quotes
(ValueWithoutQuotes)
[warning] 15-15: [ValueWithoutQuotes] This value needs to be surrounded in quotes
(ValueWithoutQuotes)
[warning] 17-17: [ValueWithoutQuotes] This value needs to be surrounded in quotes
(ValueWithoutQuotes)
[warning] 27-27: [ExtraBlankLine] Extra blank line detected
(ExtraBlankLine)
[warning] 28-28: [ExtraBlankLine] Extra blank line detected
(ExtraBlankLine)
[warning] 31-31: [ValueWithoutQuotes] This value needs to be surrounded in quotes
(ValueWithoutQuotes)
[warning] 59-59: [DuplicatedKey] The LOKI_BASIC_AUTH key is duplicated
(DuplicatedKey)
[warning] 62-62: [UnorderedKey] The LOKI_PASSWORD key should go before the LOKI_USERNAME key
(UnorderedKey)
[warning] 71-71: [DuplicatedKey] The LOG_LEVEL key is duplicated
(DuplicatedKey)
[warning] 73-73: [UnorderedKey] The LOG_ERROR_STACK key should go before the LOG_FILE key
(UnorderedKey)
[warning] 77-77: [DuplicatedKey] The ENV key is duplicated
(DuplicatedKey)
[warning] 77-77: [UnorderedKey] The ENV key should go before the NODE_ENV key
(UnorderedKey)
22831e6 to
75fc736
Compare
75fc736 to
ee25369
Compare
promatty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hooray
alexwhelan12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Environment variables can be accessed here if you have the correct permissions. Reach out to your team lead if you are missing some.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.