Skip to content

feat(ui5-carousel): adds keyboard handling and updates accessibility attributes #12256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(ui5-carousel): adds keyboard handling and updates accessibility attributes #12256

wants to merge 7 commits into from

Conversation

GerganaKremenska
Copy link
Contributor

@GerganaKremenska GerganaKremenska commented Sep 3, 2025 •
edited by kskondov
Loading

Sets focus is on the carousel items rather than the carousel itself
Ads keyboard handling for Home, End, PageUp, PageDown, F7 buttons
Updates accessibility attributes

@GerganaKremenska GerganaKremenska marked this pull request as draft September 3, 2025 14:21
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Sep 9, 2025 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ kskondov
❌ GerganaKremenska
You have signed the CLA already but the status is still pending? Let us recheck it.

@kskondov
feat(ui5-carousel): updates accessibility and adds keyboard handling
6febbf2 
Sets focus is on the carousel items rather than the carousel itself
Ads keyboard handling for Home, End, PageUp, PageDown, F7 buttons
Updates accessibility attributes
@kskondov kskondov changed the title feat(ui5-carousel): focus is on the items feat(ui5-carousel): adds keyboard handling and updates accessibility attributes Sep 25, 2025
@kskondov kskondov marked this pull request as ready for review September 25, 2025 11:04
@ui5-webcomponents-bot
Copy link
Collaborator

🚀 Preview deployment ready: https://UI5.github.io/webcomponents/pr-12256/

The preview will be updated automatically when you push new commits to this PR.

@kskondov kskondov requested a review from a team September 25, 2025 11:25
@ui5-webcomponents-bot
Copy link
Collaborator

🚀 Preview deployment ready: https://UI5.github.io/webcomponents/pr-12256/

The preview will be updated automatically when you push new commits to this PR.

@ui5-webcomponents-bot
Copy link
Collaborator

🚀 Preview deployment ready: https://UI5.github.io/webcomponents/pr-12256/

The preview will be updated automatically when you push new commits to this PR.

@kskondov
feat(ui5-carousel): adds keyboard handling and updates accessibility …
a7a9703 
…attributes

updates tests and fixes arrow display bug
@ui5-webcomponents-bot
Copy link
Collaborator

🚀 Preview deployment ready: https://UI5.github.io/webcomponents/pr-12256/

The preview will be updated automatically when you push new commits to this PR.

@ui5-webcomponents-bot
Copy link
Collaborator

🚀 Preview deployment ready: https://UI5.github.io/webcomponents/pr-12256/

The preview will be updated automatically when you push new commits to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GerganaKremenska @ui5-webcomponents-bot @kskondov