Skip to content

Conversation

TeodorTaushanov
Copy link
Contributor

No description provided.

Copy link

cla-assistant bot commented Sep 9, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with closing popups when the escape key is pressed in a mixed environment of OpenUI5 and UI5 Web Components. The fix ensures proper event handling and prevents interference between OpenUI5 and Web Component popup escape key behavior.

Key changes:

  • Added event marking utilities to prevent conflicts between popup systems
  • Modified popup registry to check for marked events before handling escape
  • Updated ComboBox escape key handling to be more selective about propagation

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/main/test/pages/DialogAndOpenUI5Dialog.html Added comprehensive test scenarios with mixed OpenUI5 and Web Component popups
packages/main/src/popup-utils/OpenedPopupsRegistry.ts Added event marking check to prevent handling already-processed escape events
packages/main/src/ComboBox.ts Refined escape key handling to only stop propagation when value is reset
packages/main/cypress/specs/OpenUI5andWebCPopups.cy.tsx Added Cypress tests for mixed popup scenarios and escape key behavior
packages/base/src/util/openui5support/eventMarking.ts New utility for marking events to prevent duplicate handling
packages/base/src/features/patchPopup.ts Added popup control patching to prevent escape handling when Web Components are above
packages/base/src/features/OpenUI5Support.ts Updated to include Dialog and Popover controls in the patching process
Comments suppressed due to low confidence (1)

packages/base/src/features/patchPopup.ts:1

  • There's a mismatch between the parameter type and the property being patched. Line 96 should patch PopupControl.prototype.onsapescape not Popup.prototype.onsapescape.
// OpenUI5's Control.js subset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant