fix(ui5-dialog): fix dialog resizing in RTL mode when max-width is set #12304
+64
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsubscribe
…On Wed, 17 Sept, 2025, 12:03 pm Dimitar Stoev, ***@***.***> wrote:
***@***.**** commented on this pull request.
Looks good.
—
Reply to this email directly, view it on GitHub
<#12304 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5T6Q74H2TNCNF4YIDEA3CT3TD6D3AVCNFSM6AAAAACGKXXRN2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEMZSHA3DOMRTHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug with dialog resizing in RTL (right-to-left) mode when a max-width CSS property is set. The issue occurred because the dialog would move unexpectedly during resizing due to incorrect left position calculations when CSS constraints affected the actual rendered width.
- Adds width assignment before calculating position deltas in RTL resize logic
- Calculates the difference between intended and actual width to adjust position correctly
- Includes comprehensive Cypress test coverage for the RTL max-width resizing scenario
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/main/src/Dialog.ts | Fixes RTL resizing logic by setting width first and calculating delta for position adjustment |
| packages/main/cypress/specs/Dialog.cy.tsx | Adds test case to verify dialog position stability during RTL resizing with max-width constraints |
TeodorTaushanov
requested changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #12294