Skip to content

fix(ui5-date-picker): add correct tooltip when picker is opened #12669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 19, 2025
Merged

fix(ui5-date-picker): add correct tooltip when picker is opened #12669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2babd07
fix(ui5-date-picker): add correct tooltip when picker is opened
tsanislavgatev Nov 12, 2025
38cc8fd
fix(ui5-time-picker): remove test cases
tsanislavgatev Nov 18, 2025
83a10de
Merge branch 'main' into tooltips-date-picker
tsanislavgatev Nov 18, 2025
256e4e4
Merge branch 'main' into tooltips-date-picker
tsanislavgatev Nov 19, 2025
f1c933a
Merge branch 'main' into tooltips-date-picker
tsanislavgatev Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions packages/main/cypress/specs/DatePicker.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1668,6 +1668,77 @@ describe("Date Picker Tests", () => {
.ui5DatePickerGetInnerInput()
.should("have.value", "0202-12-01");
});

it("DatePicker icon tooltip changes when toggling picker", () => {
cy.mount(<DatePicker />);

cy.get("[ui5-date-picker]")
.as("datePicker");

cy.get("@datePicker")
.should("not.have.attr", "open");

cy.get("@datePicker")
.shadow()
.find("ui5-icon")
.as("icon")
.should("have.attr", "accessible-name", "Open Picker");

cy.get("@datePicker")
.ui5DatePickerValueHelpIconPress();

cy.get("@datePicker")
.should("have.attr", "open");

cy.get("@icon")
.should("have.attr", "accessible-name", "Close Picker");

cy.get("@datePicker")
.ui5DatePickerValueHelpIconPress();

cy.get("@datePicker")
.should("not.have.attr", "open");

cy.get("@icon")
.should("have.attr", "accessible-name", "Open Picker");
});

it("DatePicker icon tooltip changes when using keyboard shortcuts", () => {
cy.mount(<DatePicker />);

cy.get("[ui5-date-picker]")
.as("datePicker")
.ui5DatePickerGetInnerInput()
.as("input")
.realClick()
.should("be.focused");

cy.get("@datePicker")
.shadow()
.find("ui5-icon")
.as("icon")
.should("have.attr", "accessible-name", "Open Picker");

cy.get("@input")
.realPress("F4");

cy.get("@datePicker")
.should("have.attr", "open");

cy.get("@icon")
.should("have.attr", "accessible-name", "Close Picker");

cy.get("@datePicker")
.shadow()
.find("ui5-calendar")
.realPress("Escape");

cy.get("@datePicker")
.should("not.have.attr", "open");

cy.get("@icon")
.should("have.attr", "accessible-name", "Open Picker");
});
});


Expand Down
5 changes: 5 additions & 0 deletions packages/main/src/DatePicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ import "@ui5/webcomponents-icons/dist/appointment-2.js";

import {
DATEPICKER_OPEN_ICON_TITLE,
DATEPICKER_OPEN_ICON_TITLE_OPENED,
DATEPICKER_DATE_DESCRIPTION,
DATETIME_COMPONENTS_PLACEHOLDER_PREFIX,
INPUT_SUGGESTIONS_TITLE,
Expand Down Expand Up @@ -920,6 +921,10 @@ class DatePicker extends DateComponentBase implements IFormInputElement {
}

get openIconTitle() {
if (this.open) {
return DatePicker.i18nBundle.getText(DATEPICKER_OPEN_ICON_TITLE_OPENED);
}

return DatePicker.i18nBundle.getText(DATEPICKER_OPEN_ICON_TITLE);
}

Expand Down
3 changes: 3 additions & 0 deletions packages/main/src/i18n/messagebundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@ COLORPICKER_ALPHA=Alpha
#XACT: DatePicker 'Open Picker' icon title
DATEPICKER_OPEN_ICON_TITLE=Open Picker

#XACT: DatePicker 'Open Picker' icon title when the picker is opened
DATEPICKER_OPEN_ICON_TITLE_OPENED=Close Picker

#XACT: Aria information for the Date Picker
DATEPICKER_DATE_DESCRIPTION=Date Input

Expand Down
Loading