Skip to content

feat(ui5-search): items wrapping #12681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(ui5-search): items wrapping #12681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions packages/fiori/src/themes/SearchItem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,27 @@
border: none;
}

:host(:focus-within) {
outline: var(--sapContent_FocusWidth) var(--sapContent_FocusStyle) var(--sapContent_FocusColor);
outline-offset: calc(-1 * var(--sapContent_FocusWidth) - 0.125rem);
}

:host {
border: none;
padding-top: var(--_ui5_search_item_vertical_padding);
Copy link
Contributor

@nikoletavnv nikoletavnv Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check again the top and bottom paddings of a search item in Compact and Cozy mode - they should be 0.5rem instead of 1rem/0.4375rem according to VD specs

padding-bottom: var(--_ui5_search_item_vertical_padding);
height: auto;
min-height: var(--_ui5_list_item_base_height);
padding-left: 1rem;
padding-right: 1rem;
}

.ui5-li-root {
padding: 0;
}

.ui5-li-root:focus:after {
display: none;
}

.ui5-search-item-content {
Expand Down Expand Up @@ -61,17 +80,16 @@
font-family: var(--sapFontFamily);
font-weight: normal;
color: var(--sapList_TextColor);
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
line-height: 1rem;
}

.ui5-search-item-titles-container {
overflow: hidden;
display: flex;
flex-direction: column;
justify-content: space-between;
flex: 1;
max-width: 100%;
gap: 1rem;
}

.ui5-search-item-icon {
Expand All @@ -82,13 +100,8 @@
}

:host([description]) {
height: auto;
min-height: var(--_ui5_list_item_base_height);
}

:host([description]) .ui5-search-item-content {
padding-top: .5rem;
padding-bottom: .5rem;
padding-top: 1rem;
padding-bottom: 1rem;
}

:host([description]) .ui5-search-item-description {
Expand All @@ -101,8 +114,4 @@
font-size: var(--sapFontSize);
font-weight: normal;
color: var(--sapContent_LabelColor);
margin-top: .25rem;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
}
9 changes: 9 additions & 0 deletions packages/fiori/src/themes/base/Search-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
:root {
--_ui5_search_item_vertical_padding: 1rem;
}

[data-ui5-compact-size],
.ui5-content-density-compact,
.sapUiSizeCompact {
--_ui5_search_item_vertical_padding: 0.4375rem;
}
1 change: 1 addition & 0 deletions packages/fiori/src/themes/sap_fiori_3/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
@import "../base/ViewSettingsDialog-parameters.css";
@import "../base/Wizard-parameters.css";
@import "./SearchField-parameters.css";
@import "../base/Search-parameters.css";
@import "../base/WizardTab-parameters.css";
@import "../base/DynamicPage-parameters.css";
@import "./DynamicPageTitle-parameters.css";
Expand Down
1 change: 1 addition & 0 deletions packages/fiori/src/themes/sap_fiori_3_dark/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
@import "../base/ViewSettingsDialog-parameters.css";
@import "../base/Wizard-parameters.css";
@import "./SearchField-parameters.css";
@import "../base/Search-parameters.css";
@import "../base/WizardTab-parameters.css";
@import "../base/DynamicPage-parameters.css";
@import "../base/DynamicPageTitle-parameters.css";
Expand Down
1 change: 1 addition & 0 deletions packages/fiori/src/themes/sap_fiori_3_hcb/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
@import "../base/ViewSettingsDialog-parameters.css";
@import "../base/Wizard-parameters.css";
@import "./SearchField-parameters.css";
@import "../base/Search-parameters.css";
@import "./WizardTab-parameters.css";
@import "./ShellBar-parameters.css";
@import "../base/DynamicPage-parameters.css";
Expand Down
1 change: 1 addition & 0 deletions packages/fiori/src/themes/sap_fiori_3_hcw/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
@import "../base/Wizard-parameters.css";
@import "./WizardTab-parameters.css";
@import "./SearchField-parameters.css";
@import "../base/Search-parameters.css";
@import "./ShellBar-parameters.css";
@import "../base/DynamicPage-parameters.css";
@import "./DynamicPageTitle-parameters.css";
Expand Down
2 changes: 2 additions & 0 deletions packages/fiori/src/themes/sap_horizon/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
@import "./MediaGallery-parameters.css";
@import "../base/DynamicPage-parameters.css";
@import "../base/SearchField-parameters.css";
@import "../base/Search-parameters.css";
@import "../base/Search-parameters.css";
@import "./DynamicPageTitle-parameters.css";
@import "../base/DynamicPageHeader-parameters.css";
@import "./DynamicPageHeaderActions-parameters.css";
Expand Down
1 change: 1 addition & 0 deletions packages/fiori/src/themes/sap_horizon_dark/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
@import "../base/ShellBar-parameters.css";
@import "./ShellBar-parameters.css";
@import "../base/SearchField-parameters.css";
@import "../base/Search-parameters.css";
@import "./TimelineItem-parameters.css";
@import "./SideNavigation-parameters.css";

Expand Down
1 change: 1 addition & 0 deletions packages/fiori/src/themes/sap_horizon_hcb/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
@import "./WizardTab-parameters.css";
@import "../base/DynamicPage-parameters.css";
@import "./SearchField-parameters.css";
@import "../base/Search-parameters.css";
@import "./DynamicPageTitle-parameters.css";
@import "../base/DynamicPageHeader-parameters.css";
@import "../sap_horizon/DynamicPageHeaderActions-parameters.css";
Expand Down
1 change: 1 addition & 0 deletions packages/fiori/src/themes/sap_horizon_hcw/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
@import "../base/ShellBar-parameters.css";
@import "./ShellBar-parameters.css";
@import "./SearchField-parameters.css";
@import "../base/Search-parameters.css";
@import "../base/DynamicPage-parameters.css";
@import "../base/DynamicPageTitle-parameters.css";
@import "../base/DynamicPageHeader-parameters.css";
Expand Down
6 changes: 5 additions & 1 deletion packages/fiori/test/pages/Search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@
<ui5-search>
<ui5-search-message-area slot="messageArea" description="Search for example “All my open Objects”" text="Try This!"></ui5-search-message-area>

<ui5-search-item text="List Item"></ui5-search-item>
<ui5-search-item text="List Item 1"></ui5-search-item>
<ui5-search-item text="Est nostrud aliquip culpa excepteur sunt proident cupidatat sit enim nostrud anim magna sit enim nostrud anim magna."></ui5-search-item>

<ui5-search-item text="List Item 2" description="List Item"></ui5-search-item>
<ui5-search-item text="Est nostrud aliquip culpa excepteur sunt proident cupidatat sit enim nostrud anim magna sit enim nostrud anim magna." description="Est nostrud aliquip culpa excepteur sunt proident cupidatat sit enim nostrud anim magna sit enim nostrud anim magna."></ui5-search-item>

<ui5-illustrated-message slot="illustration"></ui5-illustrated-message>

Expand Down
Loading