Skip to content

UIGF v4.1 update. #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ShikiSuen
Copy link
Contributor

@ShikiSuen ShikiSuen commented Jul 19, 2025

我先仅添加 Star Rail v3.4 新增的 gachaType enum cases。
接下来修改工作全权交给其他的 contributors 开会决定(包括版本号是否改变,等)。

closing #103


Affective immediately I will not respond to any unwelcomed review from qhy040404. His review comments will be activtely removed from my PR. His opinion against my PR will not be accounted.

(Nobody invited you this time.)

@ShikiSuen ShikiSuen requested review from Lightczx and Masterain98 and removed request for Lightczx July 19, 2025 12:25
Copy link

netlify bot commented Jul 19, 2025

Deploy Preview for uigf ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b1cb4ca
🔍 Latest deploy log https://app.netlify.com/projects/uigf/deploys/688f511b462c7a00084d2f23
😎 Deploy Preview https://deploy-preview-104--uigf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🟢 up 1 from production)
Accessibility: 95 (no change from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@Lightczx Lightczx requested a review from BTMuli July 23, 2025 05:32
Copy link
Member

@BTMuli BTMuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SRGF与UIGF需要对应抬升一个小版本,对应文档需要更新,在此之前不建议合并PR

@BTMuli
Copy link
Member

BTMuli commented Aug 2, 2025

@UIGF-org/srgf-update-audience @UIGF-org/uigf-constitutors

@ShikiSuen
Copy link
Contributor Author

@BTMuli 你们先唱票统计。我先投一票支持抬版本号(可以是v4.1 或者 v4.0.2507,2507指2025年7月)。
等你们得出结果了之后你们直接编辑 PR 合并了吧。

@ShikiSuen
Copy link
Contributor Author

另:如果希望 SRGF 永远停止更新的话,SRGF 至少需要一个更新、将 gachaType 设定为开放形式的 enum。

@ShikiSuen
Copy link
Contributor Author

Muli 的意见与 qhy 一致,于是 SRGF 废黜处理。
SRGF 页面得加上额外的文字陈清其不再受维护之事实、且得同步陈清其对 UIGF v4.0 发版之后新出现的卡池种类缺乏支持。

@ShikiSuen ShikiSuen requested review from BTMuli and qhy040404 August 3, 2025 11:51
@ShikiSuen ShikiSuen changed the title Add 2025 HSR Collab pool type enum cases for UIGFv4 and SRGFv1. UIGF v4.1 update. Aug 3, 2025
@ShikiSuen ShikiSuen removed the request for review from qhy040404 August 3, 2025 15:41
@UIGF-org UIGF-org deleted a comment from qhy040404 Aug 3, 2025
@UIGF-org UIGF-org deleted a comment from qhy040404 Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants