Open
Conversation
Contributor
|
Oh that's funny, I didn't know that the recv_pyobj worked out of the box for other python objects (although its name indicates it). We should probably add a warning about its safety though:
|
jmontp
reviewed
Apr 19, 2025
Contributor
jmontp
left a comment
jmontp
left a comment
There was a problem hiding this comment.
Looks good. Just had to remove the if condition checking the object type. Thanks for updating the example code with new test cases.
jmontp
approved these changes
Apr 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code now works for arbitrary python types. I updated the two test scripts as well, showing that it works for both a float and a dictionary. Should work for any other python type too.