Draft
Conversation
This reverts commit 5881885.
Formatters are used across the application; at least in the following places: * per-team score listing * Test against gold attack picker * Test against gold result viewer As such, they shouldn't be part of the Teams blueprint. This commit moves them up to the application scope, so that they only have to be set once.
This bootstrap class adds a horizontal scroll when the content is larger than the window.
DeepCode's analysis on #cc9469 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
This lines up much better with the format we have with the other blueprints.
This should enable us to pass extra data between the worker and the scorer.
which was duplicated as team::results() anyway.
ChandlerSwift
force-pushed
the
add-test-against-gold
branch
from
9178e25 to
5c3b735
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #103.