Re-enable AnOHM with rolling buffer forcing #1018
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunt05
force-pushed
the
feat/anohm-rolling-buffer
branch
from
cf963d4 to
43a634b
Compare
- Added rolling 24-hour forcing buffers to OHM_STATE and SUEWS_cal_Qs so StorageHeatMethod 3 now diagnoses coefficients from the most recently completed day - Refactored module_phys_anohm to consume buffered shortwave, meteorology, and anthropogenic heat series directly (removed the legacy MetForcingData_grid dependency) - Updated StorageHeatMethod documentation to clarify the trailing-day workflow and avoid confusion about forcing requirements
sunt05
force-pushed
the
feat/anohm-rolling-buffer
branch
from
43a634b to
21423fa
Compare
Preview Deployed
Note This preview is ephemeral. It will be lost when:
To restore, push any commit to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables AnOHM (Analytical Objective Hysteresis Model) without requiring access to future meteorological forcing data. Introduces a double-buffering system that accumulates hourly forcing observations in a working buffer and commits them to a coefficient buffer when the day completes.
Changes
OHM_STATEstructure for managing daily forcing seriesmodule_phys_anohmto consume pre-buffered forcing arrays instead of legacyMetForcingData_griddependencyNotes
timer%itsemantics for sub-hourly timestep support