add: rcmethod to CRITICAL_PHYSICS_PARAMS in config.py #955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
🔍 Schema Preview DeployedPreview URLs:
Production URLs (unchanged):
|
Co-authored-by: dayantur <71443948+dayantur@users.noreply.github.com>
|
🤖 I've automatically formatted the code in this PR using:
Please pull the latest changes before making further edits. |
…quired' of https://github.com/UMEP-dev/SUEWS into dayantur/validator/fix/rcmethod-physics-model-option-required
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While addressing #851, I noticed rcmethod was missing from CRITICAL_PHYSICS_PARAMS in _check_critical_null_physics_params (config.py).
This physics model option needs to be checked in pipeline/phase C along with the other model option physics.