Add ARCHETYPE_REQUIRED_PARAMS to config.py #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs to building_archetype params
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
🔍 Schema Preview DeployedPreview URLs:
Production URLs (unchanged):
|
Co-authored-by: dayantur <71443948+dayantur@users.noreply.github.com>
|
🤖 I've automatically formatted the code in this PR using:
Please pull the latest changes before making further edits. |
…uilding_archetype logic
…tebbs-on' of https://github.com/UMEP-dev/SUEWS into dayantur/validator/fix/required-archetype-params-when-stebbs-on
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
…params-when-stebbs-on
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
…uilding_archetype is absent Make _validate_stebbs continue and enumerate missing params even if building_archetype is absent. Add a small empty container instead of early-return so tests that expect "Missing required STEBBS parameters:" pass.
dayantur
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Author
|
@sunt05 seems that some tests (unrelated to this work) are failing on remote when adding this PR to merge queue. I had a look at that and all seems related to udunits2 not installed on remote? |
|
Hi @dayantur this is caused by a recent change in a dependency package - sorting it out now. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
* add ARCHETYPE_REQUIRED_PARAMS to config.py and extend _validate_stebbs to building_archetype params * style: auto-format code with ruff and fprettify Co-authored-by: dayantur <71443948+dayantur@users.noreply.github.com> * refactor _validate_stebbs to use a single logic for both stebbs and building_archetype logic * update CHANGELOG.md * fix: _validate_stebbs continue and enumerate missing params even if building_archetype is absent Make _validate_stebbs continue and enumerate missing params even if building_archetype is absent. Add a small empty container instead of early-return so tests that expect "Missing required STEBBS parameters:" pass. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…params-when-stebbs-on
sunt05
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While addressing #851, I noticed ArchetypeProperties params were missing from _validate_stebbs in config.py.
When stebbsmethod ==1, _validate_stebbs must check for parmaters in stebbs AND building_archetype blocks.