fix: cap worker pool to cgroup memory budget#5
Merged
HenryGeorgist merged 1 commit intoUSACE-Cloud-Compute:mainfrom Apr 14, 2026
Merged
fix: cap worker pool to cgroup memory budget#5HenryGeorgist merged 1 commit intoUSACE-Cloud-Compute:mainfrom
HenryGeorgist merged 1 commit intoUSACE-Cloud-Compute:mainfrom
Conversation
The vendored stormhub library defaulted to os.cpu_count()-2 workers, which inside a container reads the host CPU count and can exceed the cgroup memory ceiling — causing OOM-driven BrokenProcessPool on hosts with high CPU count relative to the container's memory budget. Resolve num_workers from: payload attribute > CC_NUM_WORKERS env > cgroup memory limit / 2 GB per worker > 1 (safe fallback). Plumb the resolved value into new_collection and translate BrokenProcessPool into an actionable RuntimeError. Includes a local reproducer (test/examples/payload-repro.json plus docker-compose.mem-limit.yaml capping the container at 3 GB) that deterministically triggers the original failure without the fix.
HenryGeorgist
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored stormhub library defaulted to os.cpu_count()-2 workers, which inside a container reads the host CPU count and can exceed the cgroup memory ceiling — causing OOM-driven BrokenProcessPool on hosts with high CPU count relative to the container's memory budget.
Resolve num_workers from: payload attribute > CC_NUM_WORKERS env >
cgroup memory limit / 2 GB per worker > 1 (safe fallback). Plumb the resolved value into new_collection and translate BrokenProcessPool into an actionable RuntimeError.
Includes a local reproducer (test/examples/payload-repro.json plus docker-compose.mem-limit.yaml capping the container at 3 GB) that deterministically triggers the original failure without the fix.