Skip to content

feature/suggest-new-username #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cedgo1997 wants to merge 4 commits into
base: f24
Choose a base branch
from
Open

feature/suggest-new-username #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a984e12
Add new util function to add random suffix when error appears
Cedgo1997 Oct 4, 2024
c847352
Add new feature translations
Cedgo1997 Oct 4, 2024
cbaadad
Implementing suffix function into register js and isolate new usernam…
Cedgo1997 Oct 4, 2024
1d5625f
Merge pull request #1 from Cedgo1997/feature/suggest-new-username
Cedgo1997 Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/language/en-GB/error.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

"invalid-pagination-value": "Invalid pagination value, must be at least %1 and at most %2",

"username-taken": "Username taken",
"username-taken": "Username taken. Maybe try",
"email-taken": "Email address is already taken.",
"email-nochange": "The email entered is the same as the email already on file.",
"email-invited": "Email was already invited",
Expand Down
2 changes: 1 addition & 1 deletion public/language/en-US/error.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"invalid-path": "Invalid path",
"folder-exists": "Folder exists",
"invalid-pagination-value": "Invalid pagination value, must be at least %1 and at most %2",
"username-taken": "Username taken",
"username-taken": "Username taken. Maybe try",
"email-taken": "Email address is already taken.",
"email-nochange": "The email entered is the same as the email already on file.",
"email-invited": "Email was already invited",
Expand Down
2 changes: 1 addition & 1 deletion public/language/es/error.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"invalid-path": "Invalid path",
"folder-exists": "Folder exists",
"invalid-pagination-value": "Número de página inválido, debe estar entre %1 y %2",
"username-taken": "Nombre de usuario ocupado",
"username-taken": "Nombre de usuario ocupado. Puedes intentar con",
"email-taken": "Email address is already taken.",
"email-nochange": "The email entered is the same as the email already on file.",
"email-invited": "Email was already invited",
Expand Down
4 changes: 2 additions & 2 deletions public/src/client/register.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ define('forum/register', [
if (results.every(obj => obj.status === 'rejected')) {
showSuccess(usernameInput, username_notify, successIcon);
} else {
showError(usernameInput, username_notify, '[[error:username-taken]]');
const newUsername = utils.addNewSuffix(username, 3);
showError(usernameInput, username_notify, '[[error:username-taken]]' + ' "' + newUsername + '"');
}

callback();
});
}
Expand Down
8 changes: 8 additions & 0 deletions public/src/utils.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,14 @@ const HTMLEntities = Object.freeze({
/* eslint-disable no-redeclare */
const utils = {
// https://github.com/substack/node-ent/blob/master/index.js
addNewSuffix: function (text, suffixLength) {
const nums = "1234567890";
let result = "";
for (let i = 0; i < suffixLength; i++) {
result += nums.charAt(Math.floor(Math.random() * nums.length));
}
return text + result;
},
decodeHTMLEntities: function (html) {
return String(html)
.replace(/&#(\d+);?/g, function (_, code) {
Expand Down