Skip to content

Traducción Exitosa del archivo: src/messaging/edit.js a TypeScript #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JMLTUnderCode wants to merge 15 commits into
base: f24
Choose a base branch
from
Open

Traducción Exitosa del archivo: src/messaging/edit.js a TypeScript #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5d13455
V1.0(No funcional). Seguir corrigiendo errores de compilacion ts a js…
JMLTUnderCode Oct 8, 2024
8b93527
V1.1(No funcional). Remover etiquetas que posiblemente generen lint a…
JMLTUnderCode Oct 8, 2024
920c8e3
Solucionado varios errores de la prueba Lint, aun quedan 34 errores p…
JMLTUnderCode Oct 9, 2024
459a862
Reduccion de errores en Linter. Total de errores encontrados 24.
JMLTUnderCode Oct 9, 2024
270b991
Actualizando rama de traduccion para aplicar linter modificado por el…
JMLTUnderCode Oct 9, 2024
ce4a64c
Inclusion de comentarios tipo eslint-disable y eslint-disable-next-li…
JMLTUnderCode Oct 10, 2024
7eda24b
Archivo JS generado por la traduccion TS con Error count 2. Esta vers…
JMLTUnderCode Oct 10, 2024
5fb4d05
Arreglo del tipado any para la funcion getMessagesData a nivel de Pro…
JMLTUnderCode Oct 10, 2024
b309b16
Archivo funcional, version final. Soluciones en el archivo TS complet…
JMLTUnderCode Oct 10, 2024
f9cc7e6
(Posible) Solucion al error inesperado en el test de GitHub, dicho er…
JMLTUnderCode Oct 10, 2024
38020c7
(Posible) Solucion al SEGUNDO error inesperado en el test de GitHub, …
JMLTUnderCode Oct 10, 2024
16df480
Inclusion de nuevo archivo JS generado por el archivo traducido TS(ed…
JMLTUnderCode Oct 10, 2024
a60add9
Actualizacion final de archivos. Dichas versiones funcionan y se inte…
JMLTUnderCode Oct 11, 2024
be89f93
Solucion al error detectado en NodeBB "user.isAdminOrGlobalMod is not…
JMLTUnderCode Oct 13, 2024
9360a05
Modificacion de importacion de modulos, la version combinada ESModule…
JMLTUnderCode Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
212 changes: 114 additions & 98 deletions src/messaging/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,105 +1,121 @@
'use strict';

/*
*******************************************************************************
************************ Universidad Simon Bolivar **************************
********* Departamento de Computacion y Tecnologia de la Informacion ********
* *
* - Trimestre: Septiembre-Diciembre 2024 *
* - Materia: Ingenieria de Software 1 *
* - Profesor: Eduardo Feo Flushing *
* *
* - Author: Junior Lara (17-10303) *
* *
* Proyecto 1B: Traducción a TypeScript o Incremento de Cobertura de Código *
* *
*******************************************************************************
*/
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
return new (P || (P = Promise))(function (resolve, reject) {
function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
step((generator = generator.apply(thisArg, _arguments || [])).next());
});
};
/* Seccion: IMPORTACIONES */
/* eslint-disable @typescript-eslint/no-var-requires */
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const meta = require('../meta');
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const user = require('../user');
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const plugins = require('../plugins');
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const privileges = require('../privileges');

// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const sockets = require('../socket.io');


/* Seccion: FUNCIONES */
module.exports = function (Messaging) {
Messaging.editMessage = async (uid, mid, roomId, content) => {
await Messaging.checkContent(content);
const raw = await Messaging.getMessageField(mid, 'content');
if (raw === content) {
return;
}

const payload = await plugins.hooks.fire('filter:messaging.edit', {
content: content,
edited: Date.now(),
});

if (!String(payload.content).trim()) {
throw new Error('[[error:invalid-chat-message]]');
}
await Messaging.setMessageFields(mid, payload);

// Propagate this change to users in the room
const messages = await Messaging.getMessagesData([mid], uid, roomId, true);
if (messages[0]) {
const roomName = messages[0].deleted ? `uid_${uid}` : `chat_room_${roomId}`;
sockets.in(roomName).emit('event:chats.edit', {
messages: messages,
});
}

plugins.hooks.fire('action:messaging.edit', {
message: { ...messages[0], content: payload.content },
});
};

const canEditDelete = async (messageId, uid, type) => {
let durationConfig = '';
if (type === 'edit') {
durationConfig = 'chatEditDuration';
} else if (type === 'delete') {
durationConfig = 'chatDeleteDuration';
}

const exists = await Messaging.messageExists(messageId);
if (!exists) {
throw new Error('[[error:invalid-mid]]');
}

const isAdminOrGlobalMod = await user.isAdminOrGlobalMod(uid);

if (meta.config.disableChat) {
throw new Error('[[error:chat-disabled]]');
} else if (!isAdminOrGlobalMod && meta.config.disableChatMessageEditing) {
throw new Error('[[error:chat-message-editing-disabled]]');
}

const userData = await user.getUserFields(uid, ['banned']);
if (userData.banned) {
throw new Error('[[error:user-banned]]');
}

const canChat = await privileges.global.can(['chat', 'chat:privileged'], uid);
if (!canChat.includes(true)) {
throw new Error('[[error:no-privileges]]');
}

const messageData = await Messaging.getMessageFields(messageId, ['fromuid', 'timestamp', 'system']);
if (isAdminOrGlobalMod && !messageData.system) {
return;
}

const chatConfigDuration = meta.config[durationConfig];
if (chatConfigDuration && Date.now() - messageData.timestamp > chatConfigDuration * 1000) {
throw new Error(`[[error:chat-${type}-duration-expired, ${meta.config[durationConfig]}]]`);
}

if (messageData.fromuid === parseInt(uid, 10) && !messageData.system) {
return;
}

throw new Error(`[[error:cant-${type}-chat-message]]`);
};

Messaging.canEdit = async (messageId, uid) => await canEditDelete(messageId, uid, 'edit');
Messaging.canDelete = async (messageId, uid) => await canEditDelete(messageId, uid, 'delete');

Messaging.canPin = async (roomId, uid) => {
const [isAdmin, isGlobalMod, inRoom, isRoomOwner] = await Promise.all([
user.isAdministrator(uid),
user.isGlobalModerator(uid),
Messaging.isUserInRoom(uid, roomId),
Messaging.isRoomOwner(uid, roomId),
]);
if (!isAdmin && !isGlobalMod && (!inRoom || !isRoomOwner)) {
throw new Error('[[error:no-privileges]]');
}
};
Messaging.editMessage = (uid, mid, roomId, content) => __awaiter(this, void 0, void 0, function* () {
yield Messaging.checkContent(content);
const raw = yield Messaging.getMessageField(mid, 'content');
if (raw === content)
return;
// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
const payload = yield plugins.hooks.fire('filter:messaging.edit', { content: content, edited: Date.now() });
if (!String(payload.content).trim())
throw new Error('[[error:invalid-chat-message]]');
yield Messaging.setMessageFields(mid, payload);
// Propagate this change to users in the room
const messages = yield Messaging.getMessagesData([mid], uid, roomId, true);
if (messages[0]) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
const roomName = messages[0].deleted ? `uid_${uid}` : `chat_room_${roomId}`;
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
sockets.in(roomName).emit('event:chats.edit', { messages: messages });
}
// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
yield plugins.hooks.fire('action:messaging.edit', { message: Object.assign(Object.assign({}, messages[0]), { content: payload.content }) });
});
const canEditDelete = (messageId, uid, type) => __awaiter(this, void 0, void 0, function* () {
let durationConfig = '';
if (type === 'edit') {
durationConfig = 'chatEditDuration';
}
else if (type === 'delete') {
durationConfig = 'chatDeleteDuration';
}
const exists = yield Messaging.messageExists(messageId);
if (!exists)
throw new Error('[[error:invalid-mid]]');
// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
const isAdminOrGlobalMod = yield user.isAdminOrGlobalMod(uid);
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
if (meta.config.disableChat) {
throw new Error('[[error:chat-disabled]]');
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
}
else if (!isAdminOrGlobalMod && meta.config.disableChatMessageEditing) {
throw new Error('[[error:chat-message-editing-disabled]]');
}
// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
const userData = yield user.getUserFields(uid, ['banned']);
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
if (userData.banned)
throw new Error('[[error:user-banned]]');
// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
const canChat = yield privileges.global.can(['chat', 'chat:privileged'], uid);
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
if (!canChat.includes(true))
throw new Error('[[error:no-privileges]]');
const messageData = yield Messaging.getMessageFields(messageId, ['fromuid', 'timestamp', 'system']);
if (isAdminOrGlobalMod && !messageData.system)
return;
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
const chatConfigDuration = meta.config[durationConfig];
if (chatConfigDuration && Date.now() - messageData.timestamp > chatConfigDuration * 1000) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
throw new Error(`[[error:chat-${type}-duration-expired, ${chatConfigDuration}]]`);
}
if (messageData.fromuid === parseInt(uid.toString(), 10) && !messageData.system)
return;
throw new Error(`[[error:cant-${type}-chat-message]]`);
});
Messaging.canEdit = (messageId, uid) => __awaiter(this, void 0, void 0, function* () { return yield canEditDelete(messageId, uid, 'edit'); });
Messaging.canDelete = (messageId, uid) => __awaiter(this, void 0, void 0, function* () { return yield canEditDelete(messageId, uid, 'delete'); });
Messaging.canPin = (roomId, uid) => __awaiter(this, void 0, void 0, function* () {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const [isAdmin, isGlobalMod, inRoom, isRoomOwner] = yield Promise.all([
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
user.isAdministrator(uid), user.isGlobalModerator(uid),
Messaging.isUserInRoom(uid, roomId), Messaging.isRoomOwner(uid, roomId),
]);
if (!isAdmin && !isGlobalMod && (!inRoom || !isRoomOwner))
throw new Error('[[error:no-privileges]]');
});
};
159 changes: 159 additions & 0 deletions src/messaging/edit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,159 @@
/*
*******************************************************************************
************************ Universidad Simon Bolivar **************************
********* Departamento de Computacion y Tecnologia de la Informacion ********
* *
* - Trimestre: Septiembre-Diciembre 2024 *
* - Materia: Ingenieria de Software 1 *
* - Profesor: Eduardo Feo Flushing *
* *
* - Author: Junior Lara (17-10303) *
* *
* Proyecto 1B: Traducción a TypeScript o Incremento de Cobertura de Código *
* *
*******************************************************************************
*/

/* Seccion: IMPORTACIONES */
/* eslint-disable @typescript-eslint/no-var-requires */
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const meta = require('../meta');
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const user = require('../user');
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const plugins = require('../plugins');
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const privileges = require('../privileges');
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const sockets = require('../socket.io');

/* Seccion: INTERFACES */
interface Payload {
content : string;
edited : number;
}

interface MessageData {
fromuid : number | string;
timestamp : number;
system : boolean;
deleted : boolean;
}

interface MessagingInterface {
editMessage : (uid: number | string, mid: number | string, roomId: number | string, content: string) => Promise<void>;
getMessageField : (mid: number | string, field: string) => Promise<string>;
setMessageFields : (mid: number | string, payload: Payload) => Promise<void>;
checkContent : (content: string | number) => Promise<void>;
getMessagesData : (
mids: (number | string)[],
uid: number | string,
roomId: number | string,
includeDeleted: boolean
) => Promise<MessageData[]>;
messageExists : (messageId: number | string) => Promise<boolean>;
getMessageFields : (messageId: number | string, fields: string[]) => Promise<MessageData>;
isUserInRoom : (uid: number | string, roomId: number | string) => Promise<boolean>;
isRoomOwner : (uid: number | string, roomId: number | string) => Promise<boolean>;
canEdit : (messageId: number | string, uid: number | string) => Promise<void>;
canDelete : (messageId: number | string, uid: number | string) => Promise<void>;
canPin : (roomId: number | string, uid: number | string) => Promise<void>;
}

/* Seccion: FUNCIONES */
module.exports = function (Messaging: MessagingInterface) {
Messaging.editMessage = async (
uid: number | string,
mid: number | string,
roomId: number | string,
content: string
): Promise<void> => {
await Messaging.checkContent(content);
const raw = await Messaging.getMessageField(mid, 'content');
if (raw === content) return;

// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
const payload: Payload = await plugins.hooks.fire('filter:messaging.edit', { content: content, edited: Date.now() });

if (!String(payload.content).trim()) throw new Error('[[error:invalid-chat-message]]');
await Messaging.setMessageFields(mid, payload);

// Propagate this change to users in the room
const messages = await Messaging.getMessagesData([mid], uid, roomId, true);
if (messages[0]) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
const roomName = messages[0].deleted ? `uid_${uid}` : `chat_room_${roomId}`;
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
sockets.in(roomName).emit('event:chats.edit', { messages: messages });
}

// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
await plugins.hooks.fire('action:messaging.edit', { message: { ...messages[0], content: payload.content } });
};

const canEditDelete = async (messageId: number | string, uid: number | string, type: 'edit' | 'delete'): Promise<void> => {
let durationConfig = '';
if (type === 'edit') {
durationConfig = 'chatEditDuration';
} else if (type === 'delete') {
durationConfig = 'chatDeleteDuration';
}

const exists: boolean = await Messaging.messageExists(messageId);
if (!exists) throw new Error('[[error:invalid-mid]]');

// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
const isAdminOrGlobalMod: boolean = await user.isAdminOrGlobalMod(uid);

// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
if (meta.config.disableChat) {
throw new Error('[[error:chat-disabled]]');
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
} else if (!isAdminOrGlobalMod && meta.config.disableChatMessageEditing) {
throw new Error('[[error:chat-message-editing-disabled]]');
}

// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
const userData = await user.getUserFields(uid, ['banned']);

// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
if (userData.banned) throw new Error('[[error:user-banned]]');

// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
const canChat: boolean[] = await privileges.global.can(['chat', 'chat:privileged'], uid);

// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
if (!canChat.includes(true)) throw new Error('[[error:no-privileges]]');

const messageData = await Messaging.getMessageFields(messageId, ['fromuid', 'timestamp', 'system']);
if (isAdminOrGlobalMod && !messageData.system) return;

// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
const chatConfigDuration: number = meta.config[durationConfig];
if (chatConfigDuration && Date.now() - messageData.timestamp > chatConfigDuration * 1000) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
throw new Error(`[[error:chat-${type}-duration-expired, ${chatConfigDuration}]]`);
}

if (messageData.fromuid === parseInt(uid.toString(), 10) && !messageData.system) return;
throw new Error(`[[error:cant-${type}-chat-message]]`);
};

Messaging.canEdit = async (messageId: number | string, uid: number | string): Promise<void> => await canEditDelete(messageId, uid, 'edit');
Messaging.canDelete = async (messageId: number | string, uid: number | string): Promise<void> => await canEditDelete(messageId, uid, 'delete');
Messaging.canPin = async (roomId: number, uid: number): Promise<void> => {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const [isAdmin, isGlobalMod, inRoom, isRoomOwner] = await Promise.all([
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-call
user.isAdministrator(uid), user.isGlobalModerator(uid),
Messaging.isUserInRoom(uid, roomId), Messaging.isRoomOwner(uid, roomId),
]);

if (!isAdmin && !isGlobalMod && (!inRoom || !isRoomOwner)) throw new Error('[[error:no-privileges]]');
};
};