Convirtiendo src/messaging/create.js de JS a TS#61
Open
Kukki8 wants to merge 7 commits intoUSB-CI3715:f24from
Open
Convirtiendo src/messaging/create.js de JS a TS#61Kukki8 wants to merge 7 commits intoUSB-CI3715:f24from
Kukki8 wants to merge 7 commits intoUSB-CI3715:f24from
Conversation
Pull Request Test Coverage Report for Build 11335176512Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolviendo issue #4
Cambios realizados:
Interfaz de Messaging: creada para definir las funciones a utilizar y los tipos de los argumentos, asi como el tipo de retorno.
Interfaz de MessageData: estructura para definir el contenido de los datos de un mensaje, utilizado a lo largo de las funciones.
Se cambio la sintaxis de las importaciones de las librerias.
Se agregaron los tipos tanto de variables como de argumentos, asi com de retorno de funciones.
Se agregaron comentarios para evitar errores a la hora de realizar el linter, por llamadas a funciones que se salen de la traduccion, cuyo valor es "any"