Skip to content

Convirtiendo src/messaging/create.js de JS a TS#61

Open
Kukki8 wants to merge 7 commits intoUSB-CI3715:f24from
Kukki8:f24
Open

Convirtiendo src/messaging/create.js de JS a TS#61
Kukki8 wants to merge 7 commits intoUSB-CI3715:f24from
Kukki8:f24

Conversation

@Kukki8
Copy link

@Kukki8 Kukki8 commented Oct 14, 2024

Resolviendo issue #4
Cambios realizados:

Interfaz de Messaging: creada para definir las funciones a utilizar y los tipos de los argumentos, asi como el tipo de retorno.
Interfaz de MessageData: estructura para definir el contenido de los datos de un mensaje, utilizado a lo largo de las funciones.

Se cambio la sintaxis de las importaciones de las librerias.
Se agregaron los tipos tanto de variables como de argumentos, asi com de retorno de funciones.

Se agregaron comentarios para evitar errores a la hora de realizar el linter, por llamadas a funciones que se salen de la traduccion, cuyo valor es "any"

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11335176512

Details

  • 76 of 81 (93.83%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 82.673%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/messaging/create.js 76 81 93.83%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 11313630816: 0.002%
Covered Lines: 22331
Relevant Lines: 25591

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants