787 tada createauml running into an error with an example tada data frame from penobscot tribal layer #797
Conversation
…le-tada-data-frame-from-penobscot-tribal-layer' of https://github.com/USEPA/EPATADA into 787-tada_createauml-running-into-an-error-with-an-example-tada-data-frame-from-penobscot-tribal-layer
|
What would the expected output be for when users specify fill_USGS_catch = TRUE in this case? I first ran: TADA_ViewATTAINS(TADA.penobscot.AUMLRef2) And I was curious to see the output with fill_USGS_catch = TRUE, and this resulted in an empty TADA dataframe. Is this expected? TADA_ViewATTAINS(TADA.penobscot.AUMLRef3) 
|
|
I will take a look at that @wokenny13 - thanks for catching that. |
…-with-an-example-tada-data-frame-from-penobscot-tribal-layer
…-with-an-example-tada-data-frame-from-penobscot-tribal-layer
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…le-tada-data-frame-from-penobscot-tribal-layer' of https://github.com/USEPA/EPATADA into 787-tada_createauml-running-into-an-error-with-an-example-tada-data-frame-from-penobscot-tribal-layer
|
@wokenny13 and @cristinamullin - it would be helpful for me if we add a quick discussion about what the desired outcome of fill_USGS_catch = TRUE is. I believe at some point there was discussion about removing the fetchNHD parts of TADA_CreateAUMLRef and separating those into a separate function. So I know there are changes still needed, I am not sure what they all are. |
…-with-an-example-tada-data-frame-from-penobscot-tribal-layer
…-with-an-example-tada-data-frame-from-penobscot-tribal-layer
…le-tada-data-frame-from-penobscot-tribal-layer' of https://github.com/USEPA/EPATADA into 787-tada_createauml-running-into-an-error-with-an-example-tada-data-frame-from-penobscot-tribal-layer
…-with-an-example-tada-data-frame-from-penobscot-tribal-layer
Corrects bug from #787
All of these examples now work, @wokenny13
`tribe <- TADA_TribalOptions(tribal_area_type = "Off-reservation Trust Lands")
TADA.penobscot <- TADA_DataRetrieval(
tribal_area_type = "Off-reservation Trust Lands",
tribe_name_parcel = "Penobscot Nation",
ask = FALSE
)
find duplicates by single org
TADA.penobscot.clean <- TADA_FindPotentialDuplicatesSingleOrg(TADA.penobscot)
find duplicates across multiple orgs
TADA.penobscot.clean <- TADA_FindPotentialDuplicatesMultipleOrgs(
TADA.penobscot.clean
)
filter duplicates
TADA.penobscot.clean <- TADA.penobscot.clean |>
dplyr::filter(TADA.SingleOrgDup.Flag == "Unique") |>
dplyr::filter(TADA.ResultSelectedMultipleOrgs == "Y")
apply censored methods for nd an od
TADA.penobscot.clean <- TADA_SimpleCensoredMethods(
TADA.penobscot.clean,
nd_method = "multiplier",
nd_multiplier = 0.5,
od_method = "as-is",
od_multiplier = "null"
)
TADA.penobscot.clean <- TADA_FindQCActivities(TADA.penobscot.clean, clean = TRUE)
run key flagging functions and clean
TADA.penobscot.clean <- TADA_RunKeyFlagFunctions(
TADA.penobscot.clean,
clean = TRUE
)
TADA.penobscot.clean <- TADA_FlagAboveThreshold(TADA.penobscot.clean, clean = TRUE, flaggedonly = FALSE)
TADA.penobscot.clean <- TADA_FlagBelowThreshold(TADA.penobscot.clean, clean = TRUE, flaggedonly = FALSE)
TADA.penobscot.clean <- TADA_HarmonizeSynonyms(TADA.penobscot.clean)
mod 2
check all orgs in ATTAINS for crosswalk
TADA.penobscot.AUMLRef <- TADA_CreateAUMLCrosswalk(
TADA.penobscot.clean,
org_id = "all",
fill_ATTAINS_catch = TRUE,
return_nearest = TRUE,
batch_upload = FALSE,
)
TADA_ViewATTAINS(TADA.penobscot.AUMLRef2)
check only MEDEP for crosswalk and geospatial matches
TADA.penobscot.AUMLRef2 <- TADA_CreateAUMLCrosswalk(
TADA.penobscot.clean,
org_id = "MEDEP",
fill_ATTAINS_catch = TRUE,
return_nearest = TRUE,
batch_upload = FALSE,
)
TADA_ViewATTAINS(TADA.penobscot.AUMLRef2)
do not check any org for crosswalk, just use spatial joins to join w/ AU from any org
TADA.penobscot.AUMLRef3 <- TADA_CreateAUMLCrosswalk(
TADA.penobscot.clean,
org_id = "none",
fill_ATTAINS_catch = TRUE,
return_nearest = TRUE,
batch_upload = FALSE,
)
TADA_ViewATTAINS(TADA.penobscot.AUMLRef3)
`
Pull Request Checklist
Preparation
Update your branch from the latest
developand resolve any merge conflictsBefore creating a pull request trigger the format-update GitHub Action on your branch to format the code
Documentation
Add/update inline and/or block comments to clarify complexity, context and intent
Add/update function documentation (roxygen), include working examples, build docs locally using devtools::document(), and inspect added/updated help pages for content and format
Add/update vignettes for corresponding changes in functionality, list these under articles in _pkgdown.yml, and ensure added/updated vignettes run and build with proper formatting locally
Maintenance & Data Refresh
Add new dependencies to
DESCRIPTIONand document appropriatelyRun spelling maintenance in
requiredMaintenance.RIf changes affect other package or the shiny app functions, update those impacted functions accordingly
If columns were added/updated, add/update them in
RequiredCols.RRun
.TADA_UpdateRefFiles()and.TADA_UpdateExampleData()locally viaMaintenanceScheduled.Ror trigger the Component File Update GitHub ActionIf new example data files were added, document them in
ExampleData.Rand include them inMaintenanceScheduled.Rfor regular refreshTests and checks
Add/update tests in
tests/testthatto cover changesRun
devtools::test()to verify new and existing tests passRun
devtools::check()and address any errors, warnings or notesPull Request Description
Includes a summary of the changes made
Includes relevant context/motivation
Includes links to related issues or pull requests (keywords like "Closes #issue_number" automatically close related issues when pull request is merged)
Review
Review the bot-commented coverage-report generated by test-coverage to confirm all changes are covered by tests
Review/accept any bot-suggested format changes
Request review from at least one developer team member