NNI functionality and vignette #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'develop' into NNI_Vignette # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…. Includes 3 ex of plots, and a few examples of data uses.
* Develop (#78) * Create coverage.yaml Init commit * Update coverage.yaml Make sure the report name is specified * Update coverage.yaml Try to get report from ./cobertura.xml * Update coverage.yaml Not there... but try being specific * Update coverage.yaml In case . is somewhere else be specific about where to write * Update coverage.yaml Simplify * Update coverage.yaml Point action to correct coverage report file * Update coverage.yaml Attempt permissions route to post comment vs PAT * Trying Jeff's epar package to generate code cov badge * incrementing dev version * Metric categories (#79) * updated params metrics function and added dontrun for examples * test passing with updates to sc and lc params functions and new sc and lc get_metric_names functions * Updating version * changes to sc_get_params and lc_get_params * fix to allow passing vectors of metric, state, county, region to both sc_get_data and sc_get_data * remove global variables messages * couple more updates to get_params functions and adding Mike as contributor * updated documentation * Increment develop branch * added try catch to functions to fail gracefully and fixed column separator in get_metric_names * added new get_metric_names example to Vignettes and last fixes to tryCatch in functions * document new functions * updated CRAN comments * Ordered vignettes in github pages * handling in vignettes for web service being down * updated CRAN comments * Updated NEWS and DESCRIPTION * updated CRAN comments * Switched most vignettes to articles * updated CRAN comments and NEWS --------- Co-authored-by: Justin Bousquin <bousquin.justin@epa.gov> Co-authored-by: Michael Dumelle <Dumelle.Michael@epa.gov>
Merge branch 'NNI_Vignette' of https://github.com/USEPA/StreamCatTools into NNI_Vignette # Conflicts: # README.md
…into NNI_Vignette
…c_get_nni Merge branch 'develop' into NNI_Vignette # Conflicts: # README.md
…create a more consistent API
mhweber
added a commit
that referenced
this pull request
Feb 3, 2026
* Develop (#78) * Create coverage.yaml Init commit * Update coverage.yaml Make sure the report name is specified * Update coverage.yaml Try to get report from ./cobertura.xml * Update coverage.yaml Not there... but try being specific * Update coverage.yaml In case . is somewhere else be specific about where to write * Update coverage.yaml Simplify * Update coverage.yaml Point action to correct coverage report file * Update coverage.yaml Attempt permissions route to post comment vs PAT * Trying Jeff's epar package to generate code cov badge * incrementing dev version * Metric categories (#79) * updated params metrics function and added dontrun for examples * test passing with updates to sc and lc params functions and new sc and lc get_metric_names functions * Updating version * changes to sc_get_params and lc_get_params * fix to allow passing vectors of metric, state, county, region to both sc_get_data and sc_get_data * remove global variables messages * couple more updates to get_params functions and adding Mike as contributor * updated documentation * Increment develop branch * added try catch to functions to fail gracefully and fixed column separator in get_metric_names * added new get_metric_names example to Vignettes and last fixes to tryCatch in functions * document new functions * updated CRAN comments * Ordered vignettes in github pages * handling in vignettes for web service being down * updated CRAN comments * Updated NEWS and DESCRIPTION * updated CRAN comments * Switched most vignettes to articles * updated CRAN comments and NEWS * NNI functionality and vignette (#85) * Nutrients vignette for eventual merge into main branch * Nutrients vignette in Rmd format rather than Qmd for vignette rendering * typo in vignette * Increment version number to 0.6.0.9000 * added lc_get_nni function * added sc_get_nni function * created lc_plot file and added lc_plot_nni function * created sc_plot file and added sc_plot_nni function * new functions for sc_plot and lc_plot codes * updates to examples * some changes to plot functions * added nni plot and nni get data functions to examples in NNI vignette. Includes 3 ex of plots, and a few examples of data uses. * Updates to Vignettes Patch (#84) * Develop (#78) * Create coverage.yaml Init commit * Update coverage.yaml Make sure the report name is specified * Update coverage.yaml Try to get report from ./cobertura.xml * Update coverage.yaml Not there... but try being specific * Update coverage.yaml In case . is somewhere else be specific about where to write * Update coverage.yaml Simplify * Update coverage.yaml Point action to correct coverage report file * Update coverage.yaml Attempt permissions route to post comment vs PAT * Trying Jeff's epar package to generate code cov badge * incrementing dev version * Metric categories (#79) * updated params metrics function and added dontrun for examples * test passing with updates to sc and lc params functions and new sc and lc get_metric_names functions * Updating version * changes to sc_get_params and lc_get_params * fix to allow passing vectors of metric, state, county, region to both sc_get_data and sc_get_data * remove global variables messages * couple more updates to get_params functions and adding Mike as contributor * updated documentation * Increment develop branch * added try catch to functions to fail gracefully and fixed column separator in get_metric_names * added new get_metric_names example to Vignettes and last fixes to tryCatch in functions * document new functions * updated CRAN comments * Ordered vignettes in github pages * handling in vignettes for web service being down * updated CRAN comments * Updated NEWS and DESCRIPTION * updated CRAN comments * Switched most vignettes to articles * updated CRAN comments and NEWS --------- Co-authored-by: Justin Bousquin <bousquin.justin@epa.gov> Co-authored-by: Michael Dumelle <Dumelle.Michael@epa.gov> * change badge to grand total * added package calls, native pipe * changed source names, transformed output dataframes to tibbles * Additions to package imports: ggpattern, patchwork, cowplot, tigris, ggplot2 * moved NNI vignette to articles * remove library() calls * corrected function call in get_nni examples * a few modifications for namespace issues * a few last updates to get NNI.Rmd to render * rename `sc_nlcd` and `lc_nlcd` to `sc_get_nlcd` and `lc_get_nlcd` to create a more consistent API --------- Co-authored-by: Markley <Markley.Selia@epa.gov> Co-authored-by: Justin Bousquin <bousquin.justin@epa.gov> Co-authored-by: Michael Dumelle <Dumelle.Michael@epa.gov> * updating testing and documentation for new NNI functionality * a couple updates to testing * updates to documentation * fix malformed example in sc_get_nni * News for v 0.10.0 release * some cleanup for R checks * added tidyselect to suggests * A couple last updates prior to CRAN minor update release * Updates to GitHub pages for v0.10.0 * updates to new function syntax in testing * slight fix to test for params * mistakenly updated this test --------- Co-authored-by: Justin Bousquin <bousquin.justin@epa.gov> Co-authored-by: Michael Dumelle <Dumelle.Michael@epa.gov> Co-authored-by: Markley <Markley.Selia@epa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new NNI functionality and vignette into develop for final testing and checking