Add unit tests for api-tools/parser/gradeLoader and api-tools/parser/profileLoader #44 #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- testdata - added a new case that had grade dist data - gradeLoader.go - changed setting of GradeMap to match loadProfiles - added error return type - removed panic - removed seperated logging for grades - fixed bug where log dir was hard coded - changed loop to use os.ReadDir - csv to map - moved file io into (fix defer in loop issue) - added error return type/ remove panic - clean up - main.go - changed mkdir to mkdir All for logging dir - use time.format instead of fmt - changed log panic on bad flags to log fatal - methods.go - moved Unmarshall File from parser_test.go - parser_test.go - moved testCourses,testSections and testProfessors from validator_test.go - added loading of above to TestMain - added gradeLoading - changed key for outputSections (fixed collision issue when parsing mulitple semesters) - added util functions FailTestIfNoPanic and FailTestIfPanic - profileLoader.go - changed to use Unmarshall file / cleanup json decoding - added error return type - sectionParser_test.go - updated to use new helper functions for panics - validator.go - minor change to logging to remove \n - validator_test.go - moved init and globals to parser_test.go - updated functions not use logs check success - updated functions that use indexMap to be work without it - this was causing tests to fail when /testdata what regenerated - added parallel calls - build.bat - gofmt formats recursively so we don't need ./... just ./ - this was causing it to try to format other my other go projects - goimports is the same
# Conflicts: # parser/validator_test.go
updated docs added test for loadgrades rewrote test for profileLoader.go updated -update fixed bugs in the test,
Contributor
|
Thank you! I will review them soon. |
…ing wrong test data in profileLoader_test.go. Make empty slice as default for schema.Professors.
Contributor
Author
|
Just noticed that I set the update flag to default to true while debugging and forgot to change it back when I pushed it. Fixed in commit above. |
Contributor
Author
|
I'm going to close this since there are going to be large changes to the grade loader and profile loader, also I think there are areas that can be improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is large but most of it isn't code just test data
Grade Loader
Tests
Profile Loader
Test
Side effects
When I wrote the other tests gradeLoading was not working (due to above bug) so I needed to update tests to support it. Once the tests were fixed I realized that none of the test cases were for sections that actually had data so I added a new test and regenerated the testdata. This caused validator_test to break since the indexMap got messed due to the tests moving around. I ended up changing alot of validator_test to match the other tests and moved the loading data the TestMain.
I changed a lot and a good bit was based on personal preference so let me know if it needs any changes. It probably does but I am unable to find anything on my own.