Comet Calendar Endpoints #313
Open
+270
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehquan19
reviewed
Jan 9, 2026
api/schema/objects.go
Outdated
| } | ||
|
|
||
| // adding the CometCalendarEvent schema type | ||
| type CometCalendarEvent struct { |
Contributor
There was a problem hiding this comment.
Here we don't really need CometCalendarEvent, do we? I think we have CalendarEvent which should suffice.
I think this is pretty much the only thing worth of mention, everything else looks good!
Member
Author
There was a problem hiding this comment.
yeah, I reviewed it... makes sense. I'll remove this schema type
Contributor
|
@simar-rekhi , I've added a comment. That's pretty much it. After that, it's good for merging. |
simar-rekhi
commented
Jan 9, 2026
Member
Author
simar-rekhi
left a comment
simar-rekhi
left a comment
There was a problem hiding this comment.
made the necessary changes.
Member
Author
|
I'm through with the code review. The build checks are also passing. Hopefully it can be merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #300
tested the code available in this PR over MongoDB Compass and Postman; works smoothly.