Skip to content

Skeleton Hotfix #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rennyhoang wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Skeleton Hotfix #708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4b99ae
Update SemesterCourseItem.tsx
rennyhoang Oct 10, 2023
1acd078
Formatting
rennyhoang Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/planner/Tiles/SemesterCourseItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export const MemoizedSemesterCourseItem = React.memo(
)}
</span>
<span className="truncate text-sm">
{title || (course.code[0] == '0' ? '' : <Skeleton />)}
{title || (course.code[0] == '0' || course.code.includes("Elective") ? '' : <Skeleton />)}
Copy link
Member

@akevinge akevinge Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a quick comment explaining the fix?

Copy link
Contributor Author

@rennyhoang rennyhoang Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, the skeleton for the course title appears based on whether or not 'title' is defined. Problem is that on a degree template, some "courses" don't have titles (placeholders like "060 Course" or "CS Guided Elective") and the skeleton on those is always there. So right now I'm just doing a check on both the existence of a title and checking if the course code isn't one of the placeholders.

Copy link
Contributor

@Jake3231 Jake3231 Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may make sense for this to be included as a comment in the code.

</span>
</div>
{!semesterLocked && (
Expand Down