-
Notifications
You must be signed in to change notification settings - Fork 19
Club card image aspect ratio (#379) #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This looks nice to me. @BK2004 what do you think? Probably worth doing the same thing to the EventCard |
TyHil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just reviewing for formality. I think we need the same changes on EventCard before merging.
My concern with using |
|
That's a reasonable concern. What about something like |
|
We could do it that way, but I’m a bit concerned it could cause visual inconsistency. If we treat logo fallbacks and custom thumbnails differently (logo = Even if we encourage a 2:1 event thumbnail, people likely won’t always export images at exactly that ratio. Using If a club creates a wide thumbnail for a particular event, I also tried applying a blurred version of the logo to fill the extra space before, since most logos are close to 1:1 but not all of them are, but it didn’t end up looking as nice as I expected. |
|
You're right, even if we encourage a 2:1 ratio, we need it to look decent with other ratios too. I think this'll do that. |
Changes