-
Notifications
You must be signed in to change notification settings - Fork 19
Ordered contacts and listed officers #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Isoscelestial
wants to merge
11
commits into
develop
Choose a base branch
from
421-ordered-contacts-and-officers
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
TyHil
requested changes
Jan 2, 2026
Member
TyHil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dnd-kit/core,@dnd-kit/sortable(for drag-and-drop sorting)Overview
displayOrdercolumn tocontactsandofficerstablescontactsandofficersclub edit procedures to handle display ordersorderfield toeditContactSchemaandeditCollaboratorSchemainput schemasNotes
The
displayOrdercolumn is only set whenever the user creates a new item or reorders the items. The check for reordering items is forgiving, as it becomes positive whenever the user has moved an item using the grab handle. There is a rudimentary client-side check for if the items are ordered identically to the start, but this will not catch every case due to the complexity involved.When this PR is merged, existing contacts and officers will have a null
displayOrder, which means their contacts and officers will be unordered by default. To fix this, each club will need to trigger the order flag by reordering their contacts or officers, saving, then undoing their changes.Database people, please review this and see if there are better ways to do the things I did.
Preview
Desktop
desktop.mp4
Mobile
mobile.mp4