All tags feature request #505
Conversation
…clubs. Also reduced the amount of top tags shown under search bar to 5 to improve layout with component.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Currently the all tags component is sitting under the tags and its using the default outlined mui style, i wasn't sure if the look we were going for was for something more similar to the Tag Pills or something slightly different so i thought slightly different might look best. |
TyHil
left a comment
TyHil
left a comment
There was a problem hiding this comment.
Looking really good! Just one technical change and a design comment.
I'm thinking a design closer to the TagPills would be nicer. Like a more icon like this:
I make that mockup with this Button but it may not be possible to open the Select with a Button
<Button
variant="contained"
disableElevation
size="small"
className="drop-shadow-[0_0_4px_rgb(0_0_0_/_0.4)]"
>
<MoreHorizIcon />
</Button>
|
|
||
| setShouldFocus(false); | ||
| scrollToResults(); | ||
| setShouldFocus(true); |
There was a problem hiding this comment.
I don't think we need to do both setShouldFocus(false) and setShouldFocus(true). Just setShouldFocus(true). Also seems TagPill doesn't call setShouldFocus(true), would you mind adding that?
There was a problem hiding this comment.
That design does look much better, Ill get that done. The design example is very useful, thank you.
…ot being called in tagPill.
Resolves #418
Created a All Tags component allowing users to better filter through clubs in the search bar.
Also reduced the amount of the top tags shown under search bar to 5 to improve layout with component.