-
Notifications
You must be signed in to change notification settings - Fork 31
Feature/calendar preview #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
change plannerSchedule and plannerCoursesTable to use snackbar provider
ab4074e to
4c09691
Compare
|
Checks for “conflicts with your schedule” don’t run when clicking from RHS, so you can select two simultaneous sections. I fixed these. I added the conflict scanner to clicks in the schedule, then realized that I could also easily filter out the previews that conflicted and did that. After reloading with some cards open, cards stay selected despite being closed I could not recreate this on my computer. Whenever the cards are closed, they should be removed from the preview schedule with setPreviewCourses. Additionally, I realized that some classes have 2 sections at the exact same time. I'm not sure how to handle this, this UI issue could be discussed at our next meeting. |
…Sections within anyways :) Co-authored-by: davis118 <davismo118@gmail.com>
Co-authored-by: davis118 <davismo118@gmail.com>
Co-authored-by: davis118 <davismo118@gmail.com>
Also set preview courses on card open Co-authored-by: davis118 <davismo118@gmail.com>
Co-authored-by: davis118 <davismo118@gmail.com>
Co-authored-by: davis118 <davismo118@gmail.com>
Co-authored-by: davis118 <davismo118@gmail.com>
Co-authored-by: davis118 <davismo118@gmail.com>
Co-authored-by: davis118 <davismo118@gmail.com>
Co-authored-by: davis118 <davismo118@gmail.com>
Co-authored-by: davis118 <davismo118@gmail.com>
…eview connect history of the feature branch but overwrite it with the refactored version of the code
fixed |
I think in this case the current idea would be that the shorter (combo) course goes to the top and gets the scoot, although that is a little bit awkward when it's multiple sections. Still think that's probably the best solution though |
…elected sections show prominently
|
Sorry for the delay. Just updated to handle all sections of selected and non-selected sections together to prevent overlap issues.
Will finish these up soon
I think 1 and 2 are in line with our current expectations but if you have better ideas we can definitely consider them! I think we want to handle scoot in classes that overlap with already-scooted classes a little differently and maybe process different days separately to deal with 3 and 4 (and the issues in the checkboxes above). I will work on these a little more and push something for them soon |






Calendar Preview Feature
Overview
Adds calendar preview system allowing users to hover over course cards to see sections overlaid on the schedule before adding them to their planner.
What Changed
Preview System:
PlannerCardnow updatespreviewCoursesstate on hover/openPlannerScheduledisplays preview sections, filtered to exclude conflicts with existing planner coursesPlannerSectiongetsonSectionClickprop for selecting preview sectionsPreviewSectionGrouphandles multiple sections at same time with popoverScoot Algorithm:
UI Enhancements:
State Management:
getSelectedSectionsandhasConflictmoved fromPlannerCoursesTabletoSharedStateProvider.tsxfor reuseSearchQueryMultiSection[]in shared state