Skip to content

Conversation

@egsch
Copy link
Contributor

@egsch egsch commented Oct 19, 2025

Overview

New PR for Section Type Grade Filter for work by @NishilJ , closes #363

The filter should filters grade distributions to only include selected types of sections. For example, if "Online" is selected:
-If a prof has no online sections historically, filter them out BUT if they are teaching online next semester, keep them in
This operates exactly like the semester filter

Tasks:

  • [ ] resolve compare issues (sreeja is fixing main compare bugs in 545 graph bug #552)
  • Update branch, resolve merge conflicts
  • Test for additional bugs on the graphs, calculations, semester filters
  • Figure out/standardize logic for removing search results when filtering & filter counts
  • Fix filter UI (make them smaller)
  • In different PR: Inside each card, at the top right, include a horizontal toggle between all, in-person, online, hybrid. This is a local override

@egsch egsch linked an issue Oct 19, 2025 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Oct 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
utd-trends Ready Ready Preview, Comment Jan 6, 2026 3:14am

@AbhiramTadepalli
Copy link
Contributor

@nl32 do you want to take a look at merging with yours?

@AbhiramTadepalli
Copy link
Contributor

Messes with Compare, need to check that out

@AbhiramTadepalli
Copy link
Contributor

AbhiramTadepalli commented Oct 19, 2025

* [ ]  Possibly in different PR, depending on timeline: Inside each card, at the top right, include a horizontal toggle between all, in-person, online, hybrid. This is a local override

Let's wait on this until we fix everything else, and merge ethan's changes in

@nl32
Copy link
Contributor

nl32 commented Oct 19, 2025

@nl32 do you want to take a look at merging with yours?

once you've reviewed it I'll handle the merge for #518, though if we could hold off on merging until we resolve the other merge conflicts that would be great.

gpa points at 0 showing in LineGraph
@egsch egsch marked this pull request as ready for review November 5, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Section type grade filter

5 participants