-
Notifications
You must be signed in to change notification settings - Fork 31
363 Feature Request: Section type grade filter (NEW) #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
egsch
wants to merge
23
commits into
develop
Choose a base branch
from
363-NEW-feature-request-section-type-grade-filter
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line graph needs to be worked on still
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@nl32 do you want to take a look at merging with yours? |
Contributor
|
Messes with Compare, need to check that out |
Contributor
Let's wait on this until we fix everything else, and merge ethan's changes in |
Contributor
gpa points at 0 showing in LineGraph
…quest-section-type-grade-filter
…quest-section-type-grade-filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
New PR for Section Type Grade Filter for work by @NishilJ , closes #363
The filter should filters grade distributions to only include selected types of sections. For example, if "Online" is selected:
-If a prof has no online sections historically, filter them out BUT if they are teaching online next semester, keep them in
This operates exactly like the semester filter
Tasks:
[ ] resolve compare issues(sreeja is fixing main compare bugs in 545 graph bug #552)