Skip to content

Conversation

@mconomos
Copy link
Contributor

@mconomos mconomos commented Jun 7, 2022

No description provided.

@mconomos mconomos requested a review from smgogarten June 7, 2022 17:10
@mconomos
Copy link
Contributor Author

mconomos commented Jun 7, 2022

@smgogarten -- I enabled returning the GxE covariance matrix to help Ingo out in this branch. Pretty much all the code was already there, just commented out. If you have 10 min to look at it, that'd be great. I'm fine with leaving this as a separate branch for now and pointing him here to get the code if that's preferable.

Copy link
Collaborator

@smgogarten smgogarten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that simple: if GxE.return.cov is set to TRUE, the value returned by testGenoSingleVar is a list instead of a data.frame, and everything downstream will break.
https://github.com/UW-GAC/GENESIS/blob/master/R/testGeno.R#L199

We would need at minimum if statements here, here and here, and the whole structure of the object returned by assocTestSingle would have to change: no longer a data.frame but a list containing a data.frame and a list of matrices. We would also need to write unit tests for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants