Bootcamp: Apilaash Yoharan #254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dechair3
reviewed
Oct 7, 2025
nucleof072rb/Core/Src/main.c
Outdated
|
|
||
| /* Private user code ---------------------------------------------------------*/ | ||
| /* USER CODE BEGIN 0 */ | ||
| #define MIN_DUTY_TIME 0.05 |
There was a problem hiding this comment.
Try to avoid using floats as best as you can
dechair3
reviewed
Oct 7, 2025
nucleof072rb/Core/Src/main.c
Outdated
| // Setup bits for ADC | ||
| SPI_TX[0] = 0b00000001; | ||
| SPI_TX[1] = 0b10000000; | ||
| SPI_TX[2] = 0b00000000; |
dechair3
reviewed
Oct 7, 2025
nucleof072rb/Core/Src/main.c
Outdated
| ADC_Value = (SPI_RX[1] & 0b00000011 << 8) | SPI_RX[2]; | ||
|
|
||
| // Converts the ADC value into an appropriate value to set the register | ||
| Register_Value = MIN_DUTY_TIME + (ADC_Value / MAX_ADC_VALUE) * (MAX_DUTY_TIME-MIN_DUTY_TIME); |
There was a problem hiding this comment.
this doesn't mesh with what you defined the MAX and MIN duty time constants to be
dechair3
reviewed
Oct 7, 2025
nucleof072rb/Core/Src/main.c
Outdated
|
|
||
|
|
||
| // Set the CS pin to low | ||
| HAL_GPIO_WritePin(CS_PIN_GPIO_Port, CS_PIN_Pin, 0); |
There was a problem hiding this comment.
This could be moved a bit up in your program
dechair3
reviewed
Oct 7, 2025
nucleof072rb/Core/Src/main.c
Outdated
| while (1) | ||
| { | ||
| // Set the CS pin to high | ||
| HAL_GPIO_WritePin(CS_PIN_GPIO_Port, CS_PIN_Pin, 1); |
There was a problem hiding this comment.
Are you sure this is how you initiate a SPI data transfer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.