Version 1: compiles with task met #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rosnaky
requested changes
Jan 4, 2026
Member
Rosnaky
left a comment
Rosnaky
left a comment
There was a problem hiding this comment.
Looks good! Just a few errors with the spi communication-I think you were missing the right diagram. Let me know if you have questions!
nucleof072rb/Core/Src/main.c
Outdated
| /* USER CODE BEGIN 4 */ | ||
| int readADC() { | ||
| uint8_t command_byte = 0b11000; | ||
| uint8_t tx[2] = {command_byte, 0x00}; |
Member
There was a problem hiding this comment.
you need to send and receive 3 bytes as per figure 6.1
nucleof072rb/Core/Src/main.c
Outdated
|
|
||
| /* USER CODE BEGIN 4 */ | ||
| int readADC() { | ||
| uint8_t command_byte = 0b11000; |
Member
There was a problem hiding this comment.
you'll need to fix this as per the comment below
| /* pull cs high*/ | ||
| HAL_GPIO_WritePin(GPIOB, GPIO_PIN_8, GPIO_PIN_SET); | ||
| /* clean up and combine rx1 and rx2 */ | ||
| rx[1] = rx[1] >> 5; |
Member
There was a problem hiding this comment.
will need to fix as per figure 6.1
nucleof072rb/Core/Src/main.c
Outdated
|
|
||
| float getTimerCounts(float pulse_width) { | ||
| /* clock period is 20,000 so that 1 timer count = 1 microsecond */ | ||
| float timer_counts = pulse_width * 1000; |
Member
There was a problem hiding this comment.
will need to change multiplier of 1000 as per https://discord.com/channels/776618956638388305/1456736379399573558/1457186617277026606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootcamp submission for Tejas Bains