-
Couldn't load subscription status.
- Fork 22
fix: shared memory for evals #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cristipufu
wants to merge
1
commit into
main
Choose a base branch
from
fix/evals_shared_memory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -1,6 +1,8 @@ | ||||
| import asyncio | ||||
| import os | ||||
| from typing import List, Optional | ||||
|
|
||||
| from langgraph.checkpoint.sqlite.aio import AsyncSqliteSaver | ||||
| from openinference.instrumentation.langchain import ( | ||||
| LangChainInstrumentor, | ||||
| get_current_span, | ||||
|
|
@@ -9,6 +11,7 @@ | |||
| from uipath._cli._evals._progress_reporter import StudioWebProgressReporter | ||||
| from uipath._cli._evals._runtime import UiPathEvalContext, UiPathEvalRuntime | ||||
| from uipath._cli._runtime._contracts import ( | ||||
| UiPathRuntimeContext, | ||||
| UiPathRuntimeFactory, | ||||
| ) | ||||
| from uipath._cli._utils._eval_set import EvalHelpers | ||||
|
|
@@ -25,6 +28,13 @@ | |||
| ) | ||||
|
|
||||
|
|
||||
| def get_connection_string(context: UiPathRuntimeContext) -> str: | ||||
| if context.runtime_dir and context.state_file: | ||||
| os.makedirs(context.runtime_dir, exist_ok=True) | ||||
| return os.path.join(context.runtime_dir, context.state_file) | ||||
| return os.path.join("__uipath", "state.db") | ||||
|
|
||||
|
|
||||
| def langgraph_eval_middleware( | ||||
| entrypoint: Optional[str], eval_set: Optional[str], eval_ids: List[str], **kwargs | ||||
| ) -> MiddlewareResult: | ||||
|
|
@@ -35,57 +45,70 @@ def langgraph_eval_middleware( | |||
| ) # Continue with normal flow if no langgraph.json | ||||
|
|
||||
| try: | ||||
| _instrument_traceable_attributes() | ||||
|
|
||||
| event_bus = EventBus() | ||||
|
|
||||
|
||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback path '__uipath/state.db' does not ensure the directory exists before returning the path. This could cause a failure when AsyncSqliteSaver attempts to create the database file if the '__uipath' directory doesn't exist. Add
os.makedirs('__uipath', exist_ok=True)before returning the fallback path.